GN: take over some exisiting bots

GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002

Committed: https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56

[mtklein_C, 2016-08-08 13:48:41]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

BUG=skia:
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein_C, 2016-08-08 14:04:55]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot
,Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86-Debug-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein_C, 2016-08-08 14:07:23]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-08 14:07:43]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot
,Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86-Debug-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86-Debug-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein_C, 2016-08-08 14:07:47]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-08-08 14:07:53]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:07:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 14:07:58]

There were warnings when CQ was processing your CL:
 * CQ is not running the
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot
trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already
specified, with these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-08 14:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:12:47]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein_C, 2016-08-08 14:23:10]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 14:23:18]

There were warnings when CQ was processing your CL:
 * CQ is not running the
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot
trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already
specified, with these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-08 14:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:28:14]

Dry run: Try jobs failed on following builders:
  Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein_C, 2016-08-10 21:58:34]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  32-bit Linux Build, Test, and Perf bots
  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86-Debug-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein_C, 2016-08-10 22:00:55]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 22:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:01:03]

There were warnings when CQ was processing your CL:
 * CQ is not running the
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot
trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already
specified, with these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-10 22:01:15]

There were warnings when CQ was processing your CL:
 * CQ is not running the
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot
trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already
specified, with these tests: ['defaulttests']

[mtklein_C, 2016-08-10 22:19:11]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[mtklein_C, 2016-08-10 22:19:20]

mtklein@chromium.org changed reviewers:
+ jcgregorio@google.com

[commit-bot: I haz the power, 2016-08-10 22:31:02]

There were warnings when CQ was processing your CL:
 * CQ is not running the
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot
trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already
specified, with these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-10 22:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:49:53]

Dry run: This issue passed the CQ dry run.

[jcgregorio, 2016-08-11 12:25:00]

On 2016/08/10 at 22:19:21, mtklein wrote:
> 

LGTM, but would like borenet to take a look since this does invert the decision
flow.

[borenet, 2016-08-11 12:29:48]

I think a better approach would be to integrate GN into the default_flavor.

https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/flavor/gn_flavor.py (right):

https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
infra/bots/recipe_modules/flavor/gn_flavor.py:10: has = lambda s: s in
self.m.vars.builder_name
Please change this to target a specific portion of the builder name, eg.
self.m.vars.builder_cfg.get('extra_config', '')

https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
infra/bots/recipe_modules/flavor/gn_flavor.py:19: has = lambda s: s in
self.m.vars.builder_name
Same here.

[mtklein, 2016-08-11 14:01:31]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein, 2016-08-11 14:03:10]

On 2016/08/11 12:29:48, borenet wrote:
> I think a better approach would be to integrate GN into the default_flavor.
> 
>
https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
> File infra/bots/recipe_modules/flavor/gn_flavor.py (right):
> 
>
https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
> infra/bots/recipe_modules/flavor/gn_flavor.py:10: has = lambda s: s in
> self.m.vars.builder_name
> Please change this to target a specific portion of the builder name, eg.
> self.m.vars.builder_cfg.get('extra_config', '')
> 
>
https://codereview.chromium.org/2229463002/diff/80001/infra/bots/recipe_modul...
> infra/bots/recipe_modules/flavor/gn_flavor.py:19: has = lambda s: s in
> self.m.vars.builder_name
> Same here.

Done.

[mtklein, 2016-08-11 14:03:15]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-11 14:03:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2229463002/#ps100001
(title: "break out has()")

[commit-bot: I haz the power, 2016-08-11 14:03:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 14:03:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 14:03:53]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SKNX_NO_SIMD-Trybot on
master.client.skia (JOB_FAILED, no build URL)

[mtklein, 2016-08-11 14:05:36]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

[mtklein, 2016-08-11 14:05:41]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-11 14:05:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 14:51:55]

Description was changed from

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
==========

to

==========
GN: take over some exisiting bots

As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002

Committed:
https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56
==========

[commit-bot: I haz the power, 2016-08-11 14:51:56]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56

[borenet, 2016-08-11 14:56:20]

On 2016/08/11 14:51:56, commit-bot: I haz the power wrote:
> Committed patchset #6 (id:100001) as
> https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56

Err, okay.  I really would've preferred that GN be integrated into the default
flavor, since we're moving in that direction.  Otherwise, the logic for when to
have gn_flavor "hijack" the normal flavor is going to get really complicated.

[mtklein, 2016-08-11 15:26:38]

On 2016/08/11 14:56:20, borenet wrote:
> On 2016/08/11 14:51:56, commit-bot: I haz the power wrote:
> > Committed patchset #6 (id:100001) as
> >
https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56
> 
> Err, okay.  I really would've preferred that GN be integrated into the default
> flavor, since we're moving in that direction.  Otherwise, the logic for when
to
> have gn_flavor "hijack" the normal flavor is going to get really complicated.

Yes, that's intentional.  I want to eliminate all the flavors except gn_
eventually.

[borenet, 2016-08-11 16:17:07]

On 2016/08/11 15:26:38, mtklein wrote:
> On 2016/08/11 14:56:20, borenet wrote:
> > On 2016/08/11 14:51:56, commit-bot: I haz the power wrote:
> > > Committed patchset #6 (id:100001) as
> > >
> https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56
> > 
> > Err, okay.  I really would've preferred that GN be integrated into the
default
> > flavor, since we're moving in that direction.  Otherwise, the logic for when
> to
> > have gn_flavor "hijack" the normal flavor is going to get really
complicated.
> 
> Yes, that's intentional.  I want to eliminate all the flavors except gn_
> eventually.

Okay, maybe I'm misunderstanding your plans, but we're always going to need
non-desktop flavors in order to test those platforms.

[mtklein, 2016-08-11 16:18:44]

On 2016/08/11 16:17:07, borenet wrote:
> On 2016/08/11 15:26:38, mtklein wrote:
> > On 2016/08/11 14:56:20, borenet wrote:
> > > On 2016/08/11 14:51:56, commit-bot: I haz the power wrote:
> > > > Committed patchset #6 (id:100001) as
> > > >
> >
https://skia.googlesource.com/skia/+/18655efb7a5da4907fe702164af26f0b9a99bf56
> > > 
> > > Err, okay.  I really would've preferred that GN be integrated into the
> default
> > > flavor, since we're moving in that direction.  Otherwise, the logic for
when
> > to
> > > have gn_flavor "hijack" the normal flavor is going to get really
> complicated.
> > 
> > Yes, that's intentional.  I want to eliminate all the flavors except gn_
> > eventually.
> 
> Okay, maybe I'm misunderstanding your plans, but we're always going to need
> non-desktop flavors in order to test those platforms.

Ah, yeah, it'll only be the building aspect of them that becomes stock-GN. 
Obviously we've got to run them weirdly.