Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: infra/bots/recipe_modules/flavor/api.py

Issue 2229463002: GN: take over some exisiting bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: break out has() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 10
(...skipping 20 matching lines...) Expand all
31 def is_android(builder_cfg): 31 def is_android(builder_cfg):
32 """Determine whether the given builder is an Android builder.""" 32 """Determine whether the given builder is an Android builder."""
33 return ('Android' in builder_cfg.get('extra_config', '') or 33 return ('Android' in builder_cfg.get('extra_config', '') or
34 builder_cfg.get('os') == 'Android') 34 builder_cfg.get('os') == 'Android')
35 35
36 36
37 def is_cmake(builder_cfg): 37 def is_cmake(builder_cfg):
38 return 'CMake' in builder_cfg.get('extra_config', '') 38 return 'CMake' in builder_cfg.get('extra_config', '')
39 39
40 40
41 def is_gn(builder_cfg):
42 return 'GN' == builder_cfg.get('extra_config', '')
43
44
45 def is_ios(builder_cfg): 41 def is_ios(builder_cfg):
46 return ('iOS' in builder_cfg.get('extra_config', '') or 42 return ('iOS' in builder_cfg.get('extra_config', '') or
47 builder_cfg.get('os') == 'iOS') 43 builder_cfg.get('os') == 'iOS')
48 44
49 45
50 def is_pdfium(builder_cfg): 46 def is_pdfium(builder_cfg):
51 return 'PDFium' in builder_cfg.get('extra_config', '') 47 return 'PDFium' in builder_cfg.get('extra_config', '')
52 48
53 49
54 def is_valgrind(builder_cfg): 50 def is_valgrind(builder_cfg):
55 return 'Valgrind' in builder_cfg.get('extra_config', '') 51 return 'Valgrind' in builder_cfg.get('extra_config', '')
56 52
57 53
58 def is_xsan(builder_cfg): 54 def is_xsan(builder_cfg):
59 return ('ASAN' in builder_cfg.get('extra_config', '') or 55 return ('ASAN' in builder_cfg.get('extra_config', '') or
60 'MSAN' in builder_cfg.get('extra_config', '') or 56 'MSAN' in builder_cfg.get('extra_config', '') or
61 'TSAN' in builder_cfg.get('extra_config', '')) 57 'TSAN' in builder_cfg.get('extra_config', ''))
62 58
63 59
64 class SkiaFlavorApi(recipe_api.RecipeApi): 60 class SkiaFlavorApi(recipe_api.RecipeApi):
65 def get_flavor(self, builder_cfg): 61 def get_flavor(self, builder_cfg):
66 """Return a flavor utils object specific to the given builder.""" 62 """Return a flavor utils object specific to the given builder."""
63 gn = gn_flavor.GNFlavorUtils(self.m)
64 if gn.supported():
65 return gn
66
67 if is_android(builder_cfg): 67 if is_android(builder_cfg):
68 return android_flavor.AndroidFlavorUtils(self.m) 68 return android_flavor.AndroidFlavorUtils(self.m)
69 elif is_cmake(builder_cfg): 69 elif is_cmake(builder_cfg):
70 return cmake_flavor.CMakeFlavorUtils(self.m) 70 return cmake_flavor.CMakeFlavorUtils(self.m)
71 elif is_gn(builder_cfg):
72 return gn_flavor.GNFlavorUtils(self.m)
73 elif is_ios(builder_cfg): 71 elif is_ios(builder_cfg):
74 return ios_flavor.iOSFlavorUtils(self.m) 72 return ios_flavor.iOSFlavorUtils(self.m)
75 elif is_pdfium(builder_cfg): 73 elif is_pdfium(builder_cfg):
76 return pdfium_flavor.PDFiumFlavorUtils(self.m) 74 return pdfium_flavor.PDFiumFlavorUtils(self.m)
77 elif is_valgrind(builder_cfg): 75 elif is_valgrind(builder_cfg):
78 return valgrind_flavor.ValgrindFlavorUtils(self.m) 76 return valgrind_flavor.ValgrindFlavorUtils(self.m)
79 elif is_xsan(builder_cfg): 77 elif is_xsan(builder_cfg):
80 return xsan_flavor.XSanFlavorUtils(self.m) 78 return xsan_flavor.XSanFlavorUtils(self.m)
81 elif builder_cfg.get('configuration') == 'Coverage': 79 elif builder_cfg.get('configuration') == 'Coverage':
82 return coverage_flavor.CoverageFlavorUtils(self.m) 80 return coverage_flavor.CoverageFlavorUtils(self.m)
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 version, 202 version,
205 VERSION_FILE_SKP, 203 VERSION_FILE_SKP,
206 self.m.vars.tmp_dir, 204 self.m.vars.tmp_dir,
207 self.m.vars.local_skp_dir, 205 self.m.vars.local_skp_dir,
208 self.device_dirs.skp_dir, 206 self.device_dirs.skp_dir,
209 test_expected_version=self.m.properties.get( 207 test_expected_version=self.m.properties.get(
210 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION), 208 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION),
211 test_actual_version=self.m.properties.get( 209 test_actual_version=self.m.properties.get(
212 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION)) 210 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION))
213 return version 211 return version
OLDNEW
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698