Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: infra/bots/recipe_modules/flavor/api.py

Issue 2229463002: GN: take over some exisiting bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: break out has() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/flavor/api.py
diff --git a/infra/bots/recipe_modules/flavor/api.py b/infra/bots/recipe_modules/flavor/api.py
index 83a3484bf7537a694d8aee846ffc91ad310144e5..0e8411de63c5431c4ce69388fd0920ff655139ab 100644
--- a/infra/bots/recipe_modules/flavor/api.py
+++ b/infra/bots/recipe_modules/flavor/api.py
@@ -38,10 +38,6 @@ def is_cmake(builder_cfg):
return 'CMake' in builder_cfg.get('extra_config', '')
-def is_gn(builder_cfg):
- return 'GN' == builder_cfg.get('extra_config', '')
-
-
def is_ios(builder_cfg):
return ('iOS' in builder_cfg.get('extra_config', '') or
builder_cfg.get('os') == 'iOS')
@@ -64,12 +60,14 @@ def is_xsan(builder_cfg):
class SkiaFlavorApi(recipe_api.RecipeApi):
def get_flavor(self, builder_cfg):
"""Return a flavor utils object specific to the given builder."""
+ gn = gn_flavor.GNFlavorUtils(self.m)
+ if gn.supported():
+ return gn
+
if is_android(builder_cfg):
return android_flavor.AndroidFlavorUtils(self.m)
elif is_cmake(builder_cfg):
return cmake_flavor.CMakeFlavorUtils(self.m)
- elif is_gn(builder_cfg):
- return gn_flavor.GNFlavorUtils(self.m)
elif is_ios(builder_cfg):
return ios_flavor.iOSFlavorUtils(self.m)
elif is_pdfium(builder_cfg):
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698