Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

WTF_LOG() is deprecated. This CL introduce STORAGE_DVLOG(level), which shows
logs with --vmodule=StorageLog=N, and SQL_DVLOG(level), which shows logs with
--vmodule=SQLLog=N, and replace WTF_LOG(StorageAPI, ...) and
WTF_LOG(SQLDatabase, ...).

This CL doesn't affect production.

BUG=596760
Committed: https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4
Cr-Commit-Position: refs/heads/master@{#411499}

[tkent, 2016-08-10 00:59:39]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:28:58]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-10 02:33:55]

tkent@chromium.org changed reviewers:
+ michaeln@chromium.org

[tkent, 2016-08-10 02:33:56]

michaeln@, would you review this please?

[michaeln, 2016-08-11 00:19:35]

lgtm but please see comments about LAZY_STREAM

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/StorageLog.h (right):

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/StorageLog.h:13: #define
STORAGE_DVLOG(verbose_level) !((verbose_level) <=
::logging::GetVlogLevel("StorageLog.h")) ? (void) 0 :
::logging::LogMessageVoidify() & VLOG_STREAM(verbose_level)
I'm not so familiar with these logging macros but can this be condensed or
simplified?

#define STORAGE_DVLOG(verbose_level) \
    LAZY_STREAM(VLOG_STREAM(verbose_level), VLOG_IS_ON(verbose_level))

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/sqlite/SQLLog.h (right):

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLLog.h:13: #define
SQL_DVLOG(verbose_level) !((verbose_level) <=
::logging::GetVlogLevel("SQLLog.h")) ? (void) 0 : ::logging::LogMessageVoidify()
& VLOG_STREAM(verbose_level)
Ditto would using LAZY_STREAM help make sense?

[tkent, 2016-08-11 22:59:41]

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/StorageLog.h (right):

https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/StorageLog.h:13: #define
STORAGE_DVLOG(verbose_level) !((verbose_level) <=
::logging::GetVlogLevel("StorageLog.h")) ? (void) 0 :
::logging::LogMessageVoidify() & VLOG_STREAM(verbose_level)
On 2016/08/11 at 00:19:35, michaeln wrote:
> I'm not so familiar with these logging macros but can this be condensed or
simplified?
> 
> #define STORAGE_DVLOG(verbose_level) \
>     LAZY_STREAM(VLOG_STREAM(verbose_level), VLOG_IS_ON(verbose_level))

You're right. We can use LAZY_STREAM.  We just need to avoid VLOG_IS_ON() here
to use a fixed file symbol.

  LAZY_STREAM(VLOG_STREAM(verbose_level), (verbose_level) <=
::logging::GetVlogLevel("StorageLog.h"))

[tkent, 2016-08-11 23:06:14]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:07:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaeln, 2016-08-11 23:51:41]

On 2016/08/11 22:59:41, tkent wrote:
>
https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webdatabase/StorageLog.h (right):
> 
>
https://codereview.chromium.org/2229213002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webdatabase/StorageLog.h:13: #define
> STORAGE_DVLOG(verbose_level) !((verbose_level) <=
> ::logging::GetVlogLevel("StorageLog.h")) ? (void) 0 :
> ::logging::LogMessageVoidify() & VLOG_STREAM(verbose_level)
> On 2016/08/11 at 00:19:35, michaeln wrote:
> > I'm not so familiar with these logging macros but can this be condensed or
> simplified?
> > 
> > #define STORAGE_DVLOG(verbose_level) \
> >     LAZY_STREAM(VLOG_STREAM(verbose_level), VLOG_IS_ON(verbose_level))
> 
> You're right. We can use LAZY_STREAM.  We just need to avoid VLOG_IS_ON() here
> to use a fixed file symbol.
> 
>   LAZY_STREAM(VLOG_STREAM(verbose_level), (verbose_level) <=
> ::logging::GetVlogLevel("StorageLog.h"))

still lgtm with or without line wraps

nit: i know its not in blink's dna, but some line wraps could help us mere
mortal code readers

#define STORAGE_DVLOG(verbose_level) \
    LAZY_STREAM(VLOG_STREAM(verbose_level), \
                ((verbose_level) <= ::logging::GetVlogLevel("StorageLog.h")))

[tkent, 2016-08-12 00:40:41]

On 2016/08/11 at 23:51:41, michaeln wrote:
> nit: i know its not in blink's dna, but some line wraps could help us mere
mortal code readers

I prefer unlimiting line length until the bulk reformatting against Blink :)

[commit-bot: I haz the power, 2016-08-12 00:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:57:51]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-12 00:58:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:04:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 01:07:28]

Description was changed from

==========
Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

WTF_LOG() is deprecated. This CL introduce STORAGE_DVLOG(level), which shows
logs with --vmodule=StorageLog=N, and SQL_DVLOG(level), which shows logs with
--vmodule=SQLLog=N, and replace WTF_LOG(StorageAPI, ...) and
WTF_LOG(SQLDatabase, ...).

This CL doesn't affect production.

BUG=596760
==========

to

==========
Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

WTF_LOG() is deprecated. This CL introduce STORAGE_DVLOG(level), which shows
logs with --vmodule=StorageLog=N, and SQL_DVLOG(level), which shows logs with
--vmodule=SQLLog=N, and replace WTF_LOG(StorageAPI, ...) and
WTF_LOG(SQLDatabase, ...).

This CL doesn't affect production.

BUG=596760

Committed: https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4
Cr-Commit-Position: refs/heads/master@{#411499}
==========

[commit-bot: I haz the power, 2016-08-12 01:07:29]

Patchset 2 (id:??) landed as
https://crrev.com/83ced803a3b4c0d55efd2a07f17af7b5809d67b4
Cr-Commit-Position: refs/heads/master@{#411499}