third_party/WebKit/Source/modules/webdatabase/StorageLog.h - Issue 2229213002: Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/StorageLog.h

Issue 2229213002: Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/sqlite/SQLLog.h » ('j') | third_party/WebKit/Source/modules/webdatabase/sqlite/SQLLog.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef StorageLog_h

	6 #define StorageLog_h

	7

	8 #include "wtf/Assertions.h"

	9

	10 #if DCHECK_IS_ON()

	11 // We can see logs with \|--v=N\| or \|--vmodule=StorageLog=N\| where N is a

	12 // verbose level.

	13 #define STORAGE_DVLOG(verbose_level) !((verbose_level) <= ::logging::GetVlogLeve l("StorageLog.h")) ? (void) 0 : ::logging::LogMessageVoidify() & VLOG_STREAM(ver bose_level)
	michaeln 2016/08/11 00:19:35 I'm not so familiar with these logging macros but I'm not so familiar with these logging macros but can this be condensed or simplified? #define STORAGE_DVLOG(verbose_level) \ LAZY_STREAM(VLOG_STREAM(verbose_level), VLOG_IS_ON(verbose_level)) tkent 2016/08/11 22:59:41 You're right. We can use LAZY_STREAM. We just nee Show quoted text On 2016/08/11 at 00:19:35, michaeln wrote: > I'm not so familiar with these logging macros but can this be condensed or simplified? > > #define STORAGE_DVLOG(verbose_level) \ > LAZY_STREAM(VLOG_STREAM(verbose_level), VLOG_IS_ON(verbose_level)) You're right. We can use LAZY_STREAM. We just need to avoid VLOG_IS_ON() here to use a fixed file symbol. LAZY_STREAM(VLOG_STREAM(verbose_level), (verbose_level) <= ::logging::GetVlogLevel("StorageLog.h"))
	14 #else

	15 #define STORAGE_DVLOG(verbose_level) EAT_STREAM_PARAMETERS

	16 #endif

	17

	18 #endif // StorageLog_h

OLD	NEW