Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp

Issue 2229213002: Web SQL: Replace WTF_LOG() with STORAGE_DVLOG() or SQL_DVLOG(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using LAZY_STREAM Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
index 603940a10a6d6fb780434f1737b96bbf87e3f6e6..d83a4cd7ecfd1370a36ac3544b90987f67d55294 100644
--- a/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
@@ -43,7 +43,7 @@
#include "modules/webdatabase/SQLTransactionCallback.h"
#include "modules/webdatabase/SQLTransactionClient.h" // FIXME: Should be used in the backend only.
#include "modules/webdatabase/SQLTransactionErrorCallback.h"
-#include "platform/Logging.h"
+#include "modules/webdatabase/StorageLog.h"
#include "wtf/StdLibExtras.h"
#include "wtf/Vector.h"
@@ -133,7 +133,9 @@ SQLTransaction::StateFunction SQLTransaction::stateFunctionFor(SQLTransactionSta
// modify is m_requestedState which is meant for this purpose.
void SQLTransaction::requestTransitToState(SQLTransactionState nextState)
{
- WTF_LOG(StorageAPI, "Scheduling %s for transaction %p\n", nameForSQLTransactionState(nextState), this);
+#if DCHECK_IS_ON()
+ STORAGE_DVLOG(1) << "Scheduling " << nameForSQLTransactionState(nextState) << " for transaction " << this;
+#endif
m_requestedState = nextState;
m_database->scheduleTransactionCallback(this);
}
@@ -321,8 +323,9 @@ bool SQLTransaction::computeNextStateAndCleanupIfNeeded()
|| m_nextState == SQLTransactionState::DeliverStatementCallback
|| m_nextState == SQLTransactionState::DeliverQuotaIncreaseCallback
|| m_nextState == SQLTransactionState::DeliverSuccessCallback);
-
- WTF_LOG(StorageAPI, "Callback %s\n", nameForSQLTransactionState(m_nextState));
+#if DCHECK_IS_ON()
+ STORAGE_DVLOG(1) << "Callback " << nameForSQLTransactionState(m_nextState);
+#endif
return false;
}

Powered by Google App Engine
This is Rietveld 408576698