Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2228993003: Nits follow-up to TaskToken CL (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@d1_fdoray_tasktoken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Nits follow-up to TaskToken CL https://codereview.chromium.org/2213263002/ BUG=553459 TBR=thestig@chromium.org (already lgtm'ed w/ nits in precursor CL) Committed: https://crrev.com/aa8b597435c5fd61e59635f1de9d40c14858bf2f Cr-Commit-Position: refs/heads/master@{#410931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/sequence_token.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sequence_token.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
gab
TBR thestig: these are the nits on your lgtm w/ nits @ https://codereview.chromium.org/2213263002/. Landing separately ...
4 years, 4 months ago (2016-08-09 15:51:19 UTC) #3
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-09 18:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228993003/1
4 years, 4 months ago (2016-08-09 22:15:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/206875) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 00:17:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228993003/1
4 years, 4 months ago (2016-08-10 00:30:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 02:47:17 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 02:50:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa8b597435c5fd61e59635f1de9d40c14858bf2f
Cr-Commit-Position: refs/heads/master@{#410931}

Powered by Google App Engine
This is Rietveld 408576698