Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: base/sequence_token.cc

Issue 2228993003: Nits follow-up to TaskToken CL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d1_fdoray_tasktoken
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/sequence_token.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/sequence_token.h" 5 #include "base/sequence_token.h"
6 6
7 #include "base/atomic_sequence_num.h" 7 #include "base/atomic_sequence_num.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/threading/thread_local.h" 10 #include "base/threading/thread_local.h"
11 11
12 namespace base { 12 namespace base {
13 13
14 namespace { 14 namespace {
15 15
16 base::StaticAtomicSequenceNumber g_sequence_token_generator; 16 base::StaticAtomicSequenceNumber g_sequence_token_generator;
17 17
18 base::StaticAtomicSequenceNumber g_task_token_generator; 18 base::StaticAtomicSequenceNumber g_task_token_generator;
19 19
20 LazyInstance<ThreadLocalPointer<const SequenceToken>>::Leaky 20 LazyInstance<ThreadLocalPointer<const SequenceToken>>::Leaky
21 tls_current_sequence_token = LAZY_INSTANCE_INITIALIZER; 21 tls_current_sequence_token = LAZY_INSTANCE_INITIALIZER;
22 22
23 LazyInstance<ThreadLocalPointer<const TaskToken>>::Leaky 23 LazyInstance<ThreadLocalPointer<const TaskToken>>::Leaky
24 tls_current_task_token = LAZY_INSTANCE_INITIALIZER; 24 tls_current_task_token = LAZY_INSTANCE_INITIALIZER;
25 25
26 } // namespace 26 } // namespace
27 27
28 bool SequenceToken::operator==(const SequenceToken& other) const { 28 bool SequenceToken::operator==(const SequenceToken& other) const {
29 return token_ == other.token_ && token_ != kInvalidSequenceToken; 29 return token_ == other.token_ && IsValid();
30 } 30 }
31 31
32 bool SequenceToken::operator!=(const SequenceToken& other) const { 32 bool SequenceToken::operator!=(const SequenceToken& other) const {
33 return !(*this == other); 33 return !(*this == other);
34 } 34 }
35 35
36 bool SequenceToken::IsValid() const { 36 bool SequenceToken::IsValid() const {
37 return token_ != kInvalidSequenceToken; 37 return token_ != kInvalidSequenceToken;
38 } 38 }
39 39
40 SequenceToken SequenceToken::Create() { 40 SequenceToken SequenceToken::Create() {
41 return SequenceToken(g_sequence_token_generator.GetNext()); 41 return SequenceToken(g_sequence_token_generator.GetNext());
42 } 42 }
43 43
44 SequenceToken SequenceToken::GetForCurrentThread() { 44 SequenceToken SequenceToken::GetForCurrentThread() {
45 const SequenceToken* current_sequence_token = 45 const SequenceToken* current_sequence_token =
46 tls_current_sequence_token.Get().Get(); 46 tls_current_sequence_token.Get().Get();
47 return current_sequence_token ? *current_sequence_token : SequenceToken(); 47 return current_sequence_token ? *current_sequence_token : SequenceToken();
48 } 48 }
49 49
50 bool TaskToken::operator==(const TaskToken& other) const { 50 bool TaskToken::operator==(const TaskToken& other) const {
51 return token_ == other.token_ && token_ != kInvalidTaskToken; 51 return token_ == other.token_ && IsValid();
52 } 52 }
53 53
54 bool TaskToken::operator!=(const TaskToken& other) const { 54 bool TaskToken::operator!=(const TaskToken& other) const {
55 return !(*this == other); 55 return !(*this == other);
56 } 56 }
57 57
58 bool TaskToken::IsValid() const { 58 bool TaskToken::IsValid() const {
59 return token_ != kInvalidTaskToken; 59 return token_ != kInvalidTaskToken;
60 } 60 }
61 61
(...skipping 17 matching lines...) Expand all
79 79
80 ScopedSetSequenceTokenForCurrentThread:: 80 ScopedSetSequenceTokenForCurrentThread::
81 ~ScopedSetSequenceTokenForCurrentThread() { 81 ~ScopedSetSequenceTokenForCurrentThread() {
82 DCHECK_EQ(tls_current_sequence_token.Get().Get(), &sequence_token_); 82 DCHECK_EQ(tls_current_sequence_token.Get().Get(), &sequence_token_);
83 DCHECK_EQ(tls_current_task_token.Get().Get(), &task_token_); 83 DCHECK_EQ(tls_current_task_token.Get().Get(), &task_token_);
84 tls_current_sequence_token.Get().Set(nullptr); 84 tls_current_sequence_token.Get().Set(nullptr);
85 tls_current_task_token.Get().Set(nullptr); 85 tls_current_task_token.Get().Set(nullptr);
86 } 86 }
87 87
88 } // namespace base 88 } // namespace base
OLDNEW
« no previous file with comments | « base/sequence_token.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698