bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional.

bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional.

This avoid having to share the same constant across different boundaries.

BUG=508904
Committed: https://crrev.com/6182935761115cffcfe261707544bf10acdfe3f5
Cr-Commit-Position: refs/heads/master@{#411073}

[ortuno, 2016-08-09 19:09:55]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 19:10:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-08-09 19:26:55]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-08-09 19:26:56]

scheib: PTAL at device/

[scheib, 2016-08-09 20:39:18]

https://codereview.chromium.org/2228953003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/2228953003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device.h:309: // this method will return
|kUnknownPower|.
Will no longer return the kUnknownPower, right? Edit this comment and remove
that constant (or is that constant still used?)

[commit-bot: I haz the power, 2016-08-09 21:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:12:16]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2016-08-09 22:08:06]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 22:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-08-09 22:10:40]

Thanks!

https://codereview.chromium.org/2228953003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/2228953003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device.h:309: // this method will return
|kUnknownPower|.
On 2016/08/09 at 20:39:18, scheib wrote:
> Will no longer return the kUnknownPower, right? Edit this comment and remove
that constant (or is that constant still used?)

Done.

[ortuno, 2016-08-09 22:12:01]

ortuno@chromium.org changed reviewers:
+ puthik@chromium.org

[ortuno, 2016-08-09 22:12:02]

puthik: PTAL at components/arc/

[puthik_chromium, 2016-08-09 22:17:36]

component/arc lgtm. Didn't look at other code.

[ortuno, 2016-08-09 22:18:30]

ortuno@chromium.org changed reviewers:
+ lhchavez@chromium.org

[ortuno, 2016-08-09 22:18:31]

lhchavez: owners review for components/arc please.

[Luis Héctor Chávez, 2016-08-09 22:24:33]

https://codereview.chromium.org/2228953003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2228953003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:256: std::move(addr), rssi ?
rssi.value() : mojom::kUnknownPower,
can you do |rssi.value_or(mojom::kUnknownPower)| all across the file?

[ortuno, 2016-08-09 22:44:59]

Thanks!

https://codereview.chromium.org/2228953003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2228953003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:256: std::move(addr), rssi ?
rssi.value() : mojom::kUnknownPower,
On 2016/08/09 at 22:24:32, Luis Héctor Chávez wrote:
> can you do |rssi.value_or(mojom::kUnknownPower)| all across the file?

Ah nice! Didn't know of value_or. Done.

[Luis Héctor Chávez, 2016-08-09 22:46:07]

components/arc/bluetooth lgtm

[ortuno, 2016-08-09 23:06:57]

ortuno@chromium.org changed reviewers:
+ stevenjb@chromium.org

[ortuno, 2016-08-09 23:06:58]

stevenjb: PTAL at extensions/

[scheib, 2016-08-09 23:42:37]

LGTM

[stevenjb, 2016-08-09 23:46:12]

RS lgtm

[ortuno, 2016-08-10 04:32:22]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-08-10 04:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from puthik@chromium.org
Link to the patchset: https://codereview.chromium.org/2228953003/#ps40001
(title: "TIL value_or")

[commit-bot: I haz the power, 2016-08-10 04:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 04:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 04:41:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2016-08-10 14:41:56]

ortuno@chromium.org changed reviewers:
+ tsepez@chromium.org

[ortuno, 2016-08-10 14:41:56]

tsepez: PTAL at components/arc/common

[Tom Sepez, 2016-08-10 17:26:25]

lgtm

[ortuno, 2016-08-10 17:28:48]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:29:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:41:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 17:44:29]

Description was changed from

==========
bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional.

This avoid having to share the same constant across different boundaries.

BUG=508904
==========

to

==========
bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional.

This avoid having to share the same constant across different boundaries.

BUG=508904

Committed: https://crrev.com/6182935761115cffcfe261707544bf10acdfe3f5
Cr-Commit-Position: refs/heads/master@{#411073}
==========

[commit-bot: I haz the power, 2016-08-10 17:44:31]

Patchset 3 (id:??) landed as
https://crrev.com/6182935761115cffcfe261707544bf10acdfe3f5
Cr-Commit-Position: refs/heads/master@{#411073}