device/bluetooth/bluetooth_classic_device_mac.h - Issue 2228953003: bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_classic_device_mac.h

Issue 2228953003: bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: TIL value_or Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/bluetooth/bluetooth_classic_device_mac.h

diff --git a/device/bluetooth/bluetooth_classic_device_mac.h b/device/bluetooth/bluetooth_classic_device_mac.h

index ec9434a55594d52ef874073068279b0b0824fc1e..bf87f5813497db18ab6d287125f50461317422d7 100644

--- a/device/bluetooth/bluetooth_classic_device_mac.h

+++ b/device/bluetooth/bluetooth_classic_device_mac.h

@@ -43,8 +43,8 @@ class BluetoothClassicDeviceMac : public BluetoothDeviceMac {

bool IsConnectable() const override;

bool IsConnecting() const override;

UUIDList GetUUIDs() const override;

- int16_t GetInquiryRSSI() const override;

- int16_t GetInquiryTxPower() const override;

+ base::Optional<int8_t> GetInquiryRSSI() const override;

+ base::Optional<int8_t> GetInquiryTxPower() const override;

bool ExpectingPinCode() const override;

bool ExpectingPasskey() const override;

bool ExpectingConfirmation() const override;

« no previous file with comments | « components/arc/common/bluetooth.mojom ('k') | device/bluetooth/bluetooth_classic_device_mac.mm » ('j') | no next file with comments »