Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: device/bluetooth/bluetooth_device_android.cc

Issue 2228953003: bluetooth: Change GetInquiryTxPower and GetInquiryRSSI to return optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: TIL value_or Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/bluetooth/bluetooth_device_android.h ('k') | device/bluetooth/bluetooth_device_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/bluetooth/bluetooth_device_android.h" 5 #include "device/bluetooth/bluetooth_device_android.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 bool BluetoothDeviceAndroid::IsConnectable() const { 132 bool BluetoothDeviceAndroid::IsConnectable() const {
133 NOTIMPLEMENTED(); 133 NOTIMPLEMENTED();
134 return false; 134 return false;
135 } 135 }
136 136
137 bool BluetoothDeviceAndroid::IsConnecting() const { 137 bool BluetoothDeviceAndroid::IsConnecting() const {
138 NOTIMPLEMENTED(); 138 NOTIMPLEMENTED();
139 return false; 139 return false;
140 } 140 }
141 141
142 int16_t BluetoothDeviceAndroid::GetInquiryRSSI() const { 142 base::Optional<int8_t> BluetoothDeviceAndroid::GetInquiryRSSI() const {
143 NOTIMPLEMENTED(); 143 NOTIMPLEMENTED();
144 return kUnknownPower; 144 return base::nullopt;
145 } 145 }
146 146
147 int16_t BluetoothDeviceAndroid::GetInquiryTxPower() const { 147 base::Optional<int8_t> BluetoothDeviceAndroid::GetInquiryTxPower() const {
148 NOTIMPLEMENTED(); 148 NOTIMPLEMENTED();
149 return kUnknownPower; 149 return base::nullopt;
150 } 150 }
151 151
152 bool BluetoothDeviceAndroid::ExpectingPinCode() const { 152 bool BluetoothDeviceAndroid::ExpectingPinCode() const {
153 NOTIMPLEMENTED(); 153 NOTIMPLEMENTED();
154 return false; 154 return false;
155 } 155 }
156 156
157 bool BluetoothDeviceAndroid::ExpectingPasskey() const { 157 bool BluetoothDeviceAndroid::ExpectingPasskey() const {
158 NOTIMPLEMENTED(); 158 NOTIMPLEMENTED();
159 return false; 159 return false;
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 AttachCurrentThread(), j_device_.obj(), 286 AttachCurrentThread(), j_device_.obj(),
287 base::android::GetApplicationContext()); 287 base::android::GetApplicationContext());
288 } 288 }
289 289
290 void BluetoothDeviceAndroid::DisconnectGatt() { 290 void BluetoothDeviceAndroid::DisconnectGatt() {
291 Java_ChromeBluetoothDevice_disconnectGatt(AttachCurrentThread(), 291 Java_ChromeBluetoothDevice_disconnectGatt(AttachCurrentThread(),
292 j_device_.obj()); 292 j_device_.obj());
293 } 293 }
294 294
295 } // namespace device 295 } // namespace device
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_device_android.h ('k') | device/bluetooth/bluetooth_device_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698