Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2228883003: Add RasterWindowContext_mac (Closed)

Created:
4 years, 4 months ago by jvanverth1
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Address comment; enable backend switching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1 line) Patch
M tools/viewer/Viewer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A tools/viewer/sk_app/mac/RasterWindowContext_mac.cpp View 1 1 chunk +153 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/mac/WindowContextFactory_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/mac/Window_mac.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jvanverth1
4 years, 4 months ago (2016-08-09 16:57:52 UTC) #3
bsalomon
lgtm, but could we have a comment somewhere in the new cpp about using SDL ...
4 years, 4 months ago (2016-08-09 17:05:48 UTC) #4
jvanverth1
On 2016/08/09 17:05:48, bsalomon wrote: > lgtm, but could we have a comment somewhere in ...
4 years, 4 months ago (2016-08-09 17:27:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228883003/20001
4 years, 4 months ago (2016-08-09 17:28:03 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 17:53:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a489e3f1fb94554cfba03e9966df1cc37dd97f70

Powered by Google App Engine
This is Rietveld 408576698