components/offline_pages/background/request_queue_in_memory_store.h - Issue 2228813003: Changes to fit better with the needs of the download manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.h

Issue 2228813003: Changes to fit better with the needs of the download manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use typedef to hide an ugly type. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue.cc ('k') | components/offline_pages/background/request_queue_in_memory_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.h

diff --git a/components/offline_pages/background/request_queue_in_memory_store.h b/components/offline_pages/background/request_queue_in_memory_store.h

index cc02921c6d94bb2b0d778e32c6bd691b92be432d..4aa68f3a5921f1edb7980a903fb3cdd99d4ece00 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.h

+++ b/components/offline_pages/background/request_queue_in_memory_store.h

@@ -30,10 +30,7 @@ class RequestQueueInMemoryStore : public RequestQueueStore {

// result will be true, but the count of deleted pages will be 0.

void RemoveRequests(const std::vector<int64_t>& request_ids,

const RemoveCallback& callback) override;

- // Remove requests by client ID. In case the |client_ids| is empty, the

- // result will be true, but the count of deleted pages will be 0.

- void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,

- const RemoveCallback& callback) override;

void Reset(const ResetCallback& callback) override;

private: