Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2228813003: Changes to fit better with the needs of the download manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use typedef to hide an ugly type. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_in_memory_store.cc
diff --git a/components/offline_pages/background/request_queue_in_memory_store.cc b/components/offline_pages/background/request_queue_in_memory_store.cc
index 32219a91616eef459ea08ab4fb7116258f781355..07372468c41177159b378ffc155d19d9981f4d70 100644
--- a/components/offline_pages/background/request_queue_in_memory_store.cc
+++ b/components/offline_pages/background/request_queue_in_memory_store.cc
@@ -4,8 +4,6 @@
#include "components/offline_pages/background/request_queue_in_memory_store.h"
-#include <set>
-
#include "base/bind.h"
#include "base/location.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -40,37 +38,22 @@ void RequestQueueInMemoryStore::AddOrUpdateRequest(
void RequestQueueInMemoryStore::RemoveRequests(
const std::vector<int64_t>& request_ids,
const RemoveCallback& callback) {
- int count = 0;
+ RequestQueue::UpdateMultipleRequestResults results;
+ RequestQueue::UpdateRequestResult result;
RequestsMap::iterator iter;
for (auto request_id : request_ids) {
iter = requests_.find(request_id);
if (iter != requests_.end()) {
requests_.erase(iter);
- ++count;
- }
- }
-
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(callback, true, count));
-}
-
-void RequestQueueInMemoryStore::RemoveRequestsByClientId(
- const std::vector<ClientId>& client_ids,
- const RemoveCallback& callback) {
- int count = 0;
-
- std::set<ClientId> client_id_set(client_ids.begin(), client_ids.end());
- for (auto iter = requests_.begin(); iter != requests_.end(); ) {
- if (client_id_set.find(iter->second.client_id()) != client_id_set.end()) {
- requests_.erase(iter++);
- ++count;
+ result = RequestQueue::UpdateRequestResult::SUCCESS;
} else {
- ++iter;
+ result = RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST;
}
+ results.push_back(std::make_pair(request_id, result));
}
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(callback, true, count));
+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+ base::Bind(callback, results));
}
void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698