Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2228813003: Changes to fit better with the needs of the download manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use typedef to hide an ugly type. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.cc
diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc
index fd4cc54a982b8047e3dad86a2683605782148880..e09b0d64cbc8d381222c52e93176a026d7a3c5de 100644
--- a/components/offline_pages/background/request_queue.cc
+++ b/components/offline_pages/background/request_queue.cc
@@ -50,14 +50,10 @@ void UpdateRequestDone(const RequestQueue::UpdateRequestCallback& callback,
// Completes the remove request call.
-void RemoveRequestDone(const RequestQueue::UpdateRequestCallback& callback,
- bool success,
- int deleted_requests_count) {
- DCHECK_EQ(1, deleted_requests_count);
- RequestQueue::UpdateRequestResult result =
- success ? RequestQueue::UpdateRequestResult::SUCCESS
- : RequestQueue::UpdateRequestResult::STORE_FAILURE;
- callback.Run(result);
+void RemoveRequestsDone(
+ const RequestQueue::RemoveRequestsCallback& callback,
+ const RequestQueue::UpdateMultipleRequestResults& results) {
+ callback.Run(results);
}
} // namespace
@@ -129,17 +125,9 @@ void RequestQueue::GetForUpdateDone(
base::Bind(&UpdateRequestDone, update_callback));
}
-void RequestQueue::RemoveRequest(int64_t request_id,
- const UpdateRequestCallback& callback) {
- std::vector<int64_t> request_ids{request_id};
- store_->RemoveRequests(request_ids, base::Bind(RemoveRequestDone, callback));
-}
-
-void RequestQueue::RemoveRequestsByClientId(
- const std::vector<ClientId>& client_ids,
- const UpdateRequestCallback& callback) {
- store_->RemoveRequestsByClientId(client_ids,
- base::Bind(RemoveRequestDone, callback));
+void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids,
+ const RemoveRequestsCallback& callback) {
+ store_->RemoveRequests(request_ids, base::Bind(RemoveRequestsDone, callback));
}
void RequestQueue::PurgeRequests(const PurgeRequestsCallback& callback) {}

Powered by Google App Engine
This is Rietveld 408576698