Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2228813003: Changes to fit better with the needs of the download manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use typedef to hide an ugly type. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index d4a9d3527a3a16e716d87e4e3b0f7435e1a38540..2cc17e8c24d7aec76fc614223999e3cf2305e5b4 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -9,7 +9,7 @@
#include <vector>
#include "base/callback.h"
-#include "components/offline_pages/offline_page_item.h"
+#include "components/offline_pages/background/request_queue.h"
namespace offline_pages {
@@ -29,8 +29,8 @@ class RequestQueueStore {
const std::vector<SavePageRequest>& /* requests */)>
GetRequestsCallback;
typedef base::Callback<void(UpdateStatus)> UpdateCallback;
- typedef base::Callback<void(bool /* success */,
- int /* number of deleted requests */)>
+ typedef base::Callback<void(
+ const RequestQueue::UpdateMultipleRequestResults&)>
RemoveCallback;
typedef base::Callback<void(bool /* success */)> ResetCallback;
@@ -52,15 +52,6 @@ class RequestQueueStore {
virtual void RemoveRequests(const std::vector<int64_t>& request_ids,
const RemoveCallback& callback) = 0;
- // Asynchronously removes requests from the store using their ClientIds.
- // Result of the update, and a number of removed pages is passed in the
- // callback. Result of remove should be false, when one of the provided items
- // couldn't be deleted, e.g. because it was missing. In case client_ids is
- // empty, though this will return true, but the count of deleted pages will be
- // 0.
- virtual void RemoveRequestsByClientId(const std::vector<ClientId>& client_ids,
- const RemoveCallback& callback) = 0;
-
// Resets the store.
virtual void Reset(const ResetCallback& callback) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698