Vendor infra_libs into build/third_party

Vendor infra_libs into build/third_party

BUG=620610
Committed: https://chromium.googlesource.com/chromium/tools/build/+/1cdbd04368d1f230bad02af3d27ae8be4cd0ac52

[dsansome, 2016-08-09 06:40:06]

dsansome@chromium.org changed reviewers:
+ agable@chromium.org, sergeyberezin@chromium.org

[dsansome, 2016-08-09 06:43:55]

This depends on https://chromium-review.googlesource.com/#/c/367099/ (the pin in
this CL will need to be updated)

[agable, 2016-08-09 16:27:10]

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py
File environment.cfg.py (right):

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py#newcode30
environment.cfg.py:30: 'httplib2/python2',
we used 'parts' because "httplib2/python2" isn't a real path on windows.

https://codereview.chromium.org/2228733003/diff/1/scripts/master/unittests/te...
File scripts/master/unittests/test_env.py (right):

https://codereview.chromium.org/2228733003/diff/1/scripts/master/unittests/te...
scripts/master/unittests/test_env.py:17: sys.path.insert(0,
os.path.join(RUNTESTS_DIR, '../..'))
use "os.pardir", not "..".
don't hard-code "/".

[Sergey Berezin, 2016-08-09 21:27:55]

Proactive LGTM - but please fix the paths to be os-independent. Thanks!

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py
File environment.cfg.py (right):

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py#newcode30
environment.cfg.py:30: 'httplib2/python2',
On 2016/08/09 16:27:10, agable wrote:
> we used 'parts' because "httplib2/python2" isn't a real path on windows.

I'd just make it os.path.join('httplib2', 'python2') explicitly here.

https://codereview.chromium.org/2228733003/diff/1/scripts/master/unittests/te...
File scripts/master/unittests/test_env.py (right):

https://codereview.chromium.org/2228733003/diff/1/scripts/master/unittests/te...
scripts/master/unittests/test_env.py:17: sys.path.insert(0,
os.path.join(RUNTESTS_DIR, '../..'))
On 2016/08/09 16:27:10, agable wrote:
> use "os.pardir", not "..".
> don't hard-code "/".

I'd use os.path.dirname(os.path.dirname(RUNTESTS_DIR)) to keep the path valid
and absolute.

[dsansome, 2016-08-10 04:57:10]

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py
File environment.cfg.py (right):

https://codereview.chromium.org/2228733003/diff/1/environment.cfg.py#newcode30
environment.cfg.py:30: 'httplib2/python2',
On 2016/08/09 16:27:10, agable wrote:
> we used 'parts' because "httplib2/python2" isn't a real path on windows.

This cargo-culted fact just isn't true.  Windows has supported / as a path
separator since MS-DOS 2.0 - it's just the shell that interprets it differently.
 https://screenshot.googleplex.com/8nBjMyi8S7S

I prefer to keep the path intact here rather than using os.path.join so it's
easier to grep for usages "httplib2/python2" in the code.

[dsansome, 2016-08-10 04:57:16]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-08-10 04:57:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 05:05:08]

Description was changed from

==========
Vendor infra_libs into build/third_party

BUG=620610
==========

to

==========
Vendor infra_libs into build/third_party

BUG=620610

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/1cdbd04368d1f230bad0...
==========

[commit-bot: I haz the power, 2016-08-10 05:05:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/1cdbd04368d1f230bad0...