Chromium Code Reviews| Index: scripts/master/unittests/test_env.py |
| diff --git a/scripts/master/unittests/test_env.py b/scripts/master/unittests/test_env.py |
| index 3728a73bc902705789a14af5b1185578eef675d5..3e4975728cdd4574d81e057f8d528c4ff3ddb8a4 100755 |
| --- a/scripts/master/unittests/test_env.py |
| +++ b/scripts/master/unittests/test_env.py |
| @@ -13,23 +13,7 @@ import sys |
| RUNTESTS_DIR = os.path.dirname(os.path.abspath(__file__)) |
| DATA_PATH = os.path.join(RUNTESTS_DIR, 'data') |
| -BASE_DIR = os.path.abspath(os.path.join(RUNTESTS_DIR, '..', '..', '..')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'buildbot_8_4p1')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'buildbot_slave_8_4')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'decorator_3_3_1')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', |
| - 'google_api_python_client')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'httplib2/python2')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'jinja2')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'markupsafe')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'mock-1.0.1')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'oauth2client')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'sqlalchemy_0_7_1')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', |
| - 'sqlalchemy_migrate_0_7_1')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'tempita_0_5')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'twisted_10_2')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'third_party', 'uritemplate')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'scripts')) |
| -sys.path.insert(0, os.path.join(BASE_DIR, 'site_config')) |
| + |
| +sys.path.insert(0, os.path.join(RUNTESTS_DIR, '../..')) |
|
agable
2016/08/09 16:27:10
use "os.pardir", not "..".
don't hard-code "/".
Sergey Berezin
2016/08/09 21:27:55
I'd use os.path.dirname(os.path.dirname(RUNTESTS_D
|
| +import common.env |
| +common.env.Install() |