Vendor infra_libs into build/third_party

environment.cfg.py

Index: environment.cfg.py
diff --git a/environment.cfg.py b/environment.cfg.py
index 2ab7a4fac55a56cb547375fe56457b741dfe631f..ab219d09a466b8b60547e101c739272f6a9f9729 100644
--- a/environment.cfg.py
+++ b/environment.cfg.py
@@ -21,24 +21,26 @@ def Extend(pythonpath, cwd):
   ]
 
   # Add 'BUILD/third_party' paths.
-  build_path += [os.path.join(third_party_base, *parts) for parts in (
-      ('buildbot_8_4p1',),
-      ('buildbot_slave_8_4',),
-      ('jinja2',),
-      ('markupsafe',),
-      ('mock-1.0.1',),
-      ('coverage-3.7.1',),
-      ('twisted_10_2',),
-      ('requests_2_10_0',),
-      ('sqlalchemy_0_7_1',),
-      ('sqlalchemy_migrate_0_7_1',),
-      ('tempita_0_5',),
-      ('decorator_3_3_1',),
-      ('setuptools-0.6c11',),
-      ('httplib2', 'python2',),
-      ('oauth2client',),
-      ('uritemplate',),
-      ('google_api_python_client',),
-      ('site-packages',),
+  build_path += [os.path.join(third_party_base, path) for path in (
+      'buildbot_8_4p1',
+      'buildbot_slave_8_4',
+      'coverage-3.7.1',
+      'decorator_3_3_1',
+      'google_api_python_client',
+      'httplib2/python2',

[agable, 2016/08/09 16:27:10]

we used 'parts' because "httplib2/python2" isn't a real path on windows.

[Sergey Berezin, 2016/08/09 21:27:55]

I'd just make it os.path.join('httplib2', 'python2') explicitly here.

[dsansome, 2016/08/10 04:57:09]

This cargo-culted fact just isn't true.  Windows has supported / as a path
separator since MS-DOS 2.0 - it's just the shell that interprets it differently.
 https://screenshot.googleplex.com/8nBjMyi8S7S

I prefer to keep the path intact here rather than using os.path.join so it's
easier to grep for usages "httplib2/python2" in the code.

+      'infra_libs',
+      'jinja2',
+      'markupsafe',
+      'mock-1.0.1',
+      'oauth2client',
+      'requests_2_10_0',
+      'setuptools-0.6c11',
+      'sqlalchemy_0_7_1',
+      'sqlalchemy_migrate_0_7_1',
+      'tempita_0_5',
+      'twisted_10_2',
+      'uritemplate',
+
+      'site-packages',
   )]
   return pythonpath.Append(*build_path)