Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2228633002: clang/win: Stop disabling symbols by default in debug builds. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Reid Kleckner, hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Stop disabling symbols by default in debug builds. We disabled them a while ago because link.exe used to take a very long time confronted with clang-cl's debug info. This is no longer the case: content.dll links in about the same time with and without debug info now. I measured that both full and incremental links of content.dll are competitive (a bit faster even) for .obj files produces by clang-cl.exe and cl.exe. (A bit under 6s with clang-cl, a bit over with cl.exe for incremental links, a bit over 50s for full links with both.) I built base_unittests with symbols and clicked around a bit in windbg, and from a cursory glance debug info seems to be working. (effectively reverts https://codereview.chromium.org/1816683002) BUG=589977 Committed: https://crrev.com/c3a7d3e5ba10c401c3a46f334241f10b373f0f94 Cr-Commit-Position: refs/heads/master@{#410458}

Patch Set 1 #

Patch Set 2 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
First to stamp wins!
4 years, 4 months ago (2016-08-08 20:13:39 UTC) #4
hans
On 2016/08/08 20:13:39, Nico (away until Mon Aug 22) wrote: > First to stamp wins! ...
4 years, 4 months ago (2016-08-08 20:22:16 UTC) #6
Nico
On 2016/08/08 20:22:16, hans wrote: > On 2016/08/08 20:13:39, Nico (away until Mon Aug 22) ...
4 years, 4 months ago (2016-08-08 20:25:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228633002/20001
4 years, 4 months ago (2016-08-08 21:08:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 21:12:59 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:15:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3a7d3e5ba10c401c3a46f334241f10b373f0f94
Cr-Commit-Position: refs/heads/master@{#410458}

Powered by Google App Engine
This is Rietveld 408576698