Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1816683002: clang/win: Enable fastbuild=1 by default for now. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable fastbuild=1 by default for now. Linking currently takes forever when building with clang/win without fastbuild=1 (see bug for details). Turn this on by default until things are usable without it again. BUG=589977 TBR=rnk Committed: https://crrev.com/28bfb18a1cf236f46860a8e0165ed36532ee5c49 Cr-Commit-Position: refs/heads/master@{#382095}

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Nico
4 years, 9 months ago (2016-03-18 20:08:51 UTC) #3
Nico
ima tbr this since I want to land https://codereview.chromium.org/1739193002/ which might motivate more people to ...
4 years, 9 months ago (2016-03-18 21:15:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816683002/20001
4 years, 9 months ago (2016-03-18 21:16:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 21:34:47 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/28bfb18a1cf236f46860a8e0165ed36532ee5c49 Cr-Commit-Position: refs/heads/master@{#382095}
4 years, 9 months ago (2016-03-18 21:37:29 UTC) #11
Reid Kleckner
lgtm I just exposed -gline-tables-only, so you can use that after we roll clang r263816 ...
4 years, 9 months ago (2016-03-18 21:59:14 UTC) #12
Reid Kleckner
I'm pretty sure this broke sbox_integration_tests with ASan, they care about debug info: https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/943 It ...
4 years, 9 months ago (2016-03-24 20:08:26 UTC) #13
Nico
4 years, 9 months ago (2016-03-24 21:22:27 UTC) #14
Message was sent while issue was closed.
On 2016/03/24 20:08:26, Reid Kleckner wrote:
> I'm pretty sure this broke sbox_integration_tests with ASan, they care about
> debug info:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/943
> 
> It looks like the builder was red until March 22 so we didn't see the failure
in
> the blamelist.

Ah possible, sorry. Should be easy to add an asan!=0, right? (No laptop with me
ATM)

Powered by Google App Engine
This is Rietveld 408576698