clang/win: Stop disabling symbols by default in debug builds.

clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977
Committed: https://crrev.com/c3a7d3e5ba10c401c3a46f334241f10b373f0f94
Cr-Commit-Position: refs/heads/master@{#410458}

[Nico, 2016-08-08 20:13:12]

Description was changed from

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

BUG=589977
==========

to

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977
==========

[Nico, 2016-08-08 20:13:24]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-08-08 20:13:39]

thakis@chromium.org changed reviewers:
+ hans@chromium.org, rnk@chromium.org

[Nico, 2016-08-08 20:13:39]

First to stamp wins!

[commit-bot: I haz the power, 2016-08-08 20:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2016-08-08 20:22:16]

On 2016/08/08 20:13:39, Nico (away until Mon Aug 22) wrote:
> First to stamp wins!

LGTM

What do I win? :-)

[Nico, 2016-08-08 20:25:45]

On 2016/08/08 20:22:16, hans wrote:
> On 2016/08/08 20:13:39, Nico (away until Mon Aug 22) wrote:
> > First to stamp wins!
> 
> LGTM
> 
> What do I win? :-)

First dibs at fixing https://llvm.org/bugs/show_bug.cgi?id=28299 -- congrats!

[commit-bot: I haz the power, 2016-08-08 21:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:06:15]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-08-08 21:07:54]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:08:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:12:58]

Description was changed from

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977
==========

to

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977
==========

[commit-bot: I haz the power, 2016-08-08 21:12:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 21:15:48]

Description was changed from

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977
==========

to

==========
clang/win: Stop disabling symbols by default in debug builds.

We disabled them a while ago because link.exe used to take a very long
time confronted with clang-cl's debug info.  This is no longer the case:
content.dll links in about the same time with and without debug info now.
I measured that both full and incremental links of content.dll are
competitive (a bit faster even) for .obj files produces by clang-cl.exe
and cl.exe.  (A bit under 6s with clang-cl, a bit over with cl.exe for
incremental links, a bit over 50s for full links with both.)

I built base_unittests with symbols and clicked around a bit in windbg,
and from a cursory glance debug info seems to be working.

(effectively reverts https://codereview.chromium.org/1816683002)

BUG=589977

Committed: https://crrev.com/c3a7d3e5ba10c401c3a46f334241f10b373f0f94
Cr-Commit-Position: refs/heads/master@{#410458}
==========

[commit-bot: I haz the power, 2016-08-08 21:15:49]

Patchset 2 (id:??) landed as
https://crrev.com/c3a7d3e5ba10c401c3a46f334241f10b373f0f94
Cr-Commit-Position: refs/heads/master@{#410458}