DescriptionRevert of tracing v2: Introduce TraceBufferWriter (patchset #6 id:100001 of https://codereview.chromium.org/2196663002/ )
Reason for revert:
Looks like the following tests are failing in "Win7 Tests (dbg)(1)":
TraceBufferWriterTest.ManyWriters
TraceBufferWriterTest.ManySmallEvents
TraceBufferWriterTest.OneWriterWithFragmentingEvents
TraceBufferWriterTest.SingleEven
Original issue's description:
> tracing v2: Introduce TraceBufferWriter
>
> TraceBufferWriter is the main building block that allows writing
> events into the trace ring buffer. TBW is responsible of exchanging
> chunks with the ring buffer and carving out events out of them.
> The expected design is 1 TraceBufferWriter per thread (% very special
> cases like worker pools which don't have a message loop).
> The major challenge is represented by the fact that events can spread
> over several chunks. TBW is responsible of owning chunks for the
> all lifetime of the event, and returning them as soon as the event
> is finalized.
> In the next CLs:
> - This code will be properly integrated with the stubs generated by
> the protozero protoc compiler plugin.
> - The actual event.proto will be introduced, and TBW::AddEvent will
> return a more structured object other than just a ProtoZeroMessage.
>
> BUG=608719
> TEST=TraceBufferWriterTest.*
>
> Committed: https://crrev.com/9cc78e4aea540c6eba8655d8557b068bde423152
> Cr-Commit-Position: refs/heads/master@{#410669}
TBR=alph@chromium.org,oysteine@chromium.org,primiano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=608719
Committed: https://crrev.com/7bced3efa7ad4e73ccf3446fb708f6c4c306a82a
Cr-Commit-Position: refs/heads/master@{#410743}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|