Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2228593004: Revert of tracing v2: Introduce TraceBufferWriter (Closed)

Created:
4 years, 4 months ago by huangs
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, kraynov
Base URL:
https://chromium.googlesource.com/chromium/src.git@proto_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of tracing v2: Introduce TraceBufferWriter (patchset #6 id:100001 of https://codereview.chromium.org/2196663002/ ) Reason for revert: Looks like the following tests are failing in "Win7 Tests (dbg)(1)": TraceBufferWriterTest.ManyWriters TraceBufferWriterTest.ManySmallEvents TraceBufferWriterTest.OneWriterWithFragmentingEvents TraceBufferWriterTest.SingleEven Original issue's description: > tracing v2: Introduce TraceBufferWriter > > TraceBufferWriter is the main building block that allows writing > events into the trace ring buffer. TBW is responsible of exchanging > chunks with the ring buffer and carving out events out of them. > The expected design is 1 TraceBufferWriter per thread (% very special > cases like worker pools which don't have a message loop). > The major challenge is represented by the fact that events can spread > over several chunks. TBW is responsible of owning chunks for the > all lifetime of the event, and returning them as soon as the event > is finalized. > In the next CLs: > - This code will be properly integrated with the stubs generated by > the protozero protoc compiler plugin. > - The actual event.proto will be introduced, and TBW::AddEvent will > return a more structured object other than just a ProtoZeroMessage. > > BUG=608719 > TEST=TraceBufferWriterTest.* > > Committed: https://crrev.com/9cc78e4aea540c6eba8655d8557b068bde423152 > Cr-Commit-Position: refs/heads/master@{#410669} TBR=alph@chromium.org,oysteine@chromium.org,primiano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608719 Committed: https://crrev.com/7bced3efa7ad4e73ccf3446fb708f6c4c306a82a Cr-Commit-Position: refs/heads/master@{#410743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -713 lines) Patch
M components/components_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/tracing.gyp View 2 chunks +0 lines, -17 lines 0 comments Download
M components/tracing/BUILD.gn View 3 chunks +0 lines, -14 lines 0 comments Download
M components/tracing/core/proto_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/tracing/core/proto_zero_message.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/core/scattered_stream_writer.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/tracing/core/scattered_stream_writer.cc View 2 chunks +1 line, -3 lines 0 comments Download
D components/tracing/core/trace_buffer_writer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/tracing/core/trace_buffer_writer.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D components/tracing/core/trace_buffer_writer_unittest.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/core/trace_ring_buffer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/tracing/core/trace_ring_buffer_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
D components/tracing/proto/events_chunk.proto View 1 chunk +0 lines, -35 lines 0 comments Download
M components/tracing/test/fake_scattered_buffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
huangs
Created Revert of tracing v2: Introduce TraceBufferWriter
4 years, 4 months ago (2016-08-09 18:11:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228593004/1
4 years, 4 months ago (2016-08-09 18:12:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 18:14:37 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:23:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bced3efa7ad4e73ccf3446fb708f6c4c306a82a
Cr-Commit-Position: refs/heads/master@{#410743}

Powered by Google App Engine
This is Rietveld 408576698