Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2228233003: Remove false positive from override hint (issue 27046) (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 4 chunks +13 lines, -3 lines 1 comment Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 5 chunks +15 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 6 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 8 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-10 00:36:22 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2228233003/diff/1/pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart File pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart (right): https://codereview.chromium.org/2228233003/diff/1/pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart#newcode61 pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart:61: {bool includeAbstractFromSuperclasses: false}) { At some point we ...
4 years, 4 months ago (2016-08-10 01:23:38 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-10 13:12:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07850a6562cd6d60b2042af8c85e247e2731499a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698