pkg/analyzer/lib/src/generated/resolver.dart - Issue 2228233003: Remove false positive from override hint (issue 27046)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2228233003: Remove false positive from override hint (issue 27046) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 194d87690f72eebe2ab12d7c5ea863d3e573599f..1b36af4acaf9316a4af2c5c3d81420008e099c3e 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -4217,7 +4217,8 @@ class HintGenerator {

_usedImportedElementsVisitor =

new GatherUsedImportedElementsVisitor(_library);

_enableDart2JSHints = _context.analysisOptions.dart2jsHint;

- _manager = new InheritanceManager(_library);

+ _manager =

+ new InheritanceManager(_library, includeAbstractFromSuperclasses: true);

_usedLocalElementsVisitor = new GatherUsedLocalElementsVisitor(_library);

}