Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2228233003: Remove false positive from override hint (issue 27046) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.task.dart; 5 library analyzer.src.task.dart;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/token.dart'; 10 import 'package:analyzer/dart/ast/token.dart';
(...skipping 3230 matching lines...) Expand 10 before | Expand all | Expand 10 after
3241 new UsedLocalElements.merge(usedLocalElementsList); 3241 new UsedLocalElements.merge(usedLocalElementsList);
3242 UnusedLocalElementsVerifier visitor = 3242 UnusedLocalElementsVerifier visitor =
3243 new UnusedLocalElementsVerifier(errorListener, usedElements); 3243 new UnusedLocalElementsVerifier(errorListener, usedElements);
3244 unitElement.accept(visitor); 3244 unitElement.accept(visitor);
3245 } 3245 }
3246 // Dart2js analysis. 3246 // Dart2js analysis.
3247 if (analysisOptions.dart2jsHint) { 3247 if (analysisOptions.dart2jsHint) {
3248 unit.accept(new Dart2JSVerifier(errorReporter)); 3248 unit.accept(new Dart2JSVerifier(errorReporter));
3249 } 3249 }
3250 // Dart best practices. 3250 // Dart best practices.
3251 InheritanceManager inheritanceManager = 3251 InheritanceManager inheritanceManager = new InheritanceManager(
3252 new InheritanceManager(libraryElement); 3252 libraryElement,
3253 includeAbstractFromSuperclasses: true);
3253 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT); 3254 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
3254 3255
3255 unit.accept(new BestPracticesVerifier( 3256 unit.accept(new BestPracticesVerifier(
3256 errorReporter, typeProvider, libraryElement, 3257 errorReporter, typeProvider, libraryElement,
3257 typeSystem: typeSystem)); 3258 typeSystem: typeSystem));
3258 unit.accept(new OverrideVerifier(errorReporter, inheritanceManager)); 3259 unit.accept(new OverrideVerifier(errorReporter, inheritanceManager));
3259 // Find to-do comments. 3260 // Find to-do comments.
3260 new ToDoFinder(errorReporter).findIn(unit); 3261 new ToDoFinder(errorReporter).findIn(unit);
3261 // 3262 //
3262 // Record outputs. 3263 // Record outputs.
(...skipping 3319 matching lines...) Expand 10 before | Expand all | Expand 10 after
6582 6583
6583 @override 6584 @override
6584 bool moveNext() { 6585 bool moveNext() {
6585 if (_newSources.isEmpty) { 6586 if (_newSources.isEmpty) {
6586 return false; 6587 return false;
6587 } 6588 }
6588 currentTarget = _newSources.removeLast(); 6589 currentTarget = _newSources.removeLast();
6589 return true; 6590 return true;
6590 } 6591 }
6591 } 6592 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698