Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2227953002: [NTP Snippets] Add kArticleSuggestionsFeature (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, Philipp Keck
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add kArticleSuggestionsFeature This allows us to turn off article suggestions, without turning off the whole below-the-fold feature. BUG=none Committed: https://crrev.com/5bc62a8764ac6b005c185526f58ed82b39413268 Cr-Commit-Position: refs/heads/master@{#410634}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +40 lines, -36 lines 0 comments Download
M components/ntp_snippets/features.h View 1 chunk +5 lines, -0 lines 2 comments Download
M components/ntp_snippets/features.cc View 1 chunk +3 lines, -0 lines 3 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Marc Treib
PTAL! https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.h File components/ntp_snippets/features.h (right): https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.h#newcode14 components/ntp_snippets/features.h:14: extern const base::Feature kBookmarkSuggestionsFeature; Probably kNTPOfflinePageSuggestionsFeature should also ...
4 years, 4 months ago (2016-08-09 10:18:53 UTC) #2
jkrcal
A drive-by comment: https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc File components/ntp_snippets/features.cc (right): https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc#newcode10 components/ntp_snippets/features.cc:10: "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; I discussed with Patrick ...
4 years, 4 months ago (2016-08-09 10:27:25 UTC) #6
Bernhard Bauer
lgtm https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.h File components/ntp_snippets/features.h (right): https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.h#newcode14 components/ntp_snippets/features.h:14: extern const base::Feature kBookmarkSuggestionsFeature; On 2016/08/09 10:18:53, Marc ...
4 years, 4 months ago (2016-08-09 10:27:36 UTC) #7
Marc Treib
https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc File components/ntp_snippets/features.cc (right): https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc#newcode10 components/ntp_snippets/features.cc:10: "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; On 2016/08/09 10:27:24, jkrcal wrote: > I ...
4 years, 4 months ago (2016-08-09 10:30:13 UTC) #8
jkrcal
https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc File components/ntp_snippets/features.cc (right): https://codereview.chromium.org/2227953002/diff/1/components/ntp_snippets/features.cc#newcode10 components/ntp_snippets/features.cc:10: "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; On 2016/08/09 10:30:13, Marc Treib wrote: > ...
4 years, 4 months ago (2016-08-09 11:07:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227953002/1
4 years, 4 months ago (2016-08-09 11:15:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 11:30:39 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 11:33:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bc62a8764ac6b005c185526f58ed82b39413268
Cr-Commit-Position: refs/heads/master@{#410634}

Powered by Google App Engine
This is Rietveld 408576698