[NTP Snippets] Add kArticleSuggestionsFeature

components/ntp_snippets/features.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/features.h"
 
 namespace ntp_snippets {
 
+const base::Feature kArticleSuggestionsFeature{
+    "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};

[jkrcal, 2016/08/09 10:27:24]

I discussed with Patrick on a related bug 622776 that we want to have all of
these features disabled by default (even those that already got through reviews)
and enable them only by Finch.

The reason is to be always on the safe side and keep it consistent across all
ntp-content features.

WDYT?

[Marc Treib, 2016/08/09 10:30:13]

Hm. Default-disabling it now would mean we'd have to update all our existing
Finch configs. What I'm doing keeps the existing behavior.
Since the global toggle will default to false for the foreseeable future, I
think this is safe. But I don't feel *that* strongly, so if somebody really
objects...

[jkrcal, 2016/08/09 11:07:49]

No, I don't feel strongly either. Feel free to land it. Still I would like the
finch configs (for consistency) to eventually list all the features including
this one.

+
 const base::Feature kBookmarkSuggestionsFeature{
     "NTPBookmarkSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kContentSuggestionsFeature{
     "NTPSnippets", base::FEATURE_DISABLED_BY_DEFAULT};
 
 }  // namespace ntp_snippets