Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2221123003: [NTP Snippets] Move kOfflinePageSuggestionsFeature into the component (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, asvitkine+watch_chromium.org, Philipp Keck
Base URL:
https://chromium.googlesource.com/chromium/src.git@articles_feature
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Move kOfflinePageSuggestionsFeature into the component The code it controls lives there, so the feature itself should be there too. BUG=none Committed: https://crrev.com/672848c7a822dd8ebaed43d661b69a6567fefb89 Cr-Commit-Position: refs/heads/master@{#410645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/ntp_snippets/features.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Marc Treib
PTAL!
4 years, 4 months ago (2016-08-09 11:32:39 UTC) #4
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-09 12:39:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221123003/1
4 years, 4 months ago (2016-08-09 12:40:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 12:45:14 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 12:48:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/672848c7a822dd8ebaed43d661b69a6567fefb89
Cr-Commit-Position: refs/heads/master@{#410645}

Powered by Google App Engine
This is Rietveld 408576698