String::contains should use StringView.

String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the String
allocations for contains callers. Unfortunately it didn't fix
AtomicString which didn't use a template.

Lets make the API surface consistent across AtomicString and String
and fix all the string allocations for AtomicString::contains().

BUG=615174
Committed: https://crrev.com/95f6bad9ec8883e5596a3069ea3458c109a01ca5
Cr-Commit-Position: refs/heads/master@{#410590}

[esprehn, 2016-08-09 03:52:25]

Description was changed from

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the string
allocations for contains, but it's brittle so lets make the usage of
StringView here explicit.

I also made the API surface consistent across AtomicString and String.

BUG=615174
==========

to

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the string
allocations for contains callers, but it's not obvious so lets make
the usage of StringView here explicit.

I also made the API surface consistent across AtomicString and String.

BUG=615174
==========

[esprehn, 2016-08-09 03:52:29]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 03:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-09 04:17:40]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[esprehn, 2016-08-09 04:20:13]

Description was changed from

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the string
allocations for contains callers, but it's not obvious so lets make
the usage of StringView here explicit.

I also made the API surface consistent across AtomicString and String.

BUG=615174
==========

to

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the String
allocations for contains callers. Unfortunately it didn't fix
AtomicString which didn't use a template.

Lets make the API surface consistent across AtomicString and String
and fix all the string allocations for AtomicString::contains().

BUG=615174
==========

[esprehn, 2016-08-09 04:39:05]

https://codereview.chromium.org/2227903002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/HTTPParsers.cpp (left):

https://codereview.chromium.org/2227903002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/HTTPParsers.cpp:189: return
name.containsOnlyLatin1() && !name.contains('\r') && !name.contains('\n') &&
!name.contains(static_cast<UChar>('\0'));
There's no reason to upcast to UChar here, we just end up downcasting again
here:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/text/Strin...

[haraken, 2016-08-09 04:46:23]

Nice catch! LGTM.

[esprehn, 2016-08-09 05:00:34]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-08-09 05:00:36]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-09 05:00:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 05:41:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 05:42:44]

Description was changed from

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the String
allocations for contains callers. Unfortunately it didn't fix
AtomicString which didn't use a template.

Lets make the API surface consistent across AtomicString and String
and fix all the string allocations for AtomicString::contains().

BUG=615174
==========

to

==========
String::contains should use StringView.

By happy accident the template overload of contains made the patch in
https://codereview.chromium.org/2225173002 remove all of the String
allocations for contains callers. Unfortunately it didn't fix
AtomicString which didn't use a template.

Lets make the API surface consistent across AtomicString and String
and fix all the string allocations for AtomicString::contains().

BUG=615174

Committed: https://crrev.com/95f6bad9ec8883e5596a3069ea3458c109a01ca5
Cr-Commit-Position: refs/heads/master@{#410590}
==========

[commit-bot: I haz the power, 2016-08-09 05:42:45]

Patchset 1 (id:??) landed as
https://crrev.com/95f6bad9ec8883e5596a3069ea3458c109a01ca5
Cr-Commit-Position: refs/heads/master@{#410590}