third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp - Issue 2227903002: String::contains should use StringView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

Issue 2227903002: String::contains should use StringView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

diff --git a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

index 129722eaeddc5e70e93e710ac510423424ec560b..e5411981807b5d3b5f5ef5ba5ee937b6c4fa652b 100644

--- a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

+++ b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

@@ -293,7 +293,7 @@ const char* atomicCanonicalTextEncodingName(const String& alias)

if (!alias.length())

return 0;

- if (alias.contains(static_cast<UChar>('\0')))

+ if (alias.contains('\0'))

return 0;

if (alias.is8Bit())