String::contains should use StringView.

third_party/WebKit/Source/platform/network/HTTPParsers.cpp

 /*
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 168 matching lines @@
     option = String(begin, length);
     return position + 1;
 }
 
 
 bool isValidHTTPHeaderValue(const String& name)
 {
     // FIXME: This should really match name against
     // field-value in section 4.2 of RFC 2616.
 
-    return name.containsOnlyLatin1() && !name.contains('\r') && !name.contains('\n') && !name.contains(static_cast<UChar>('\0'));

[esprehn, 2016/08/09 04:39:04]

There's no reason to upcast to UChar here, we just end up downcasting again
here:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/text/Strin...

+    return name.containsOnlyLatin1()
+        && !name.contains('\r')
+        && !name.contains('\n')
+        && !name.contains('\0');
 }
 
 // See RFC 7230, Section 3.2.
 // Checks whether |value| matches field-content in RFC 7230.
 // link: http://tools.ietf.org/html/rfc7230#section-3.2
 bool isValidHTTPFieldContentRFC7230(const String& value)
 {
     if (value.isEmpty())
         return false;
 
@@ skipping 546 matching lines @@
         if (option == Suborigin::SuboriginPolicyOptions::None)
             messages.append("Ignoring unknown suborigin policy option " + optionName + ".");
         else
             suborigin->addPolicyOption(option);
     }
 
     return true;
 }
 
 } // namespace blink