Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2227663002:
[test] Split Ignition mjsunit expectations for variants. (Closed)
|
Created:
4 years, 4 months ago by Michael Starzinger Modified:
4 years, 4 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-variants-2 Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Split Ignition mjsunit expectations for variants.
R=rmcilroy@chromium.org
Committed: https://crrev.com/b531266da18af293c5ae9a80248b5bdf96568eb6
Cr-Commit-Position: refs/heads/master@{#38483}
Patch Set 1 #Patch Set 2 : Rebased. #
Total comments: 2
Patch Set 3 : Move to top level. #Patch Set 4 : Rebased. #Patch Set 5 : Fix more. #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)
Description was changed from ========== [test] Split Ignition mjsunit expectations for variants. R= ========== to ========== [test] Split Ignition mjsunit expectations for variants. R=rmcilroy@chromium.org ==========
mstarzinger@chromium.org changed reviewers: + rmcilroy@chromium.org
https://codereview.chromium.org/2227663002/diff/20001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2227663002/diff/20001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:405: 'es6/tail-call-megatest*': [PASS, ['variant == ignition', SKIP]], I don't think you can do this with the new variant options - I think they have to be top level.
https://codereview.chromium.org/2227663002/diff/20001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2227663002/diff/20001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:405: 'es6/tail-call-megatest*': [PASS, ['variant == ignition', SKIP]], On 2016/08/08 14:23:39, rmcilroy wrote: > I don't think you can do this with the new variant options - I think they have > to be top level. Done. Yep, also realized that while sending it to the CQ. Fixed by moving it into the ignition section.
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks.
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Split Ignition mjsunit expectations for variants. R=rmcilroy@chromium.org ========== to ========== [test] Split Ignition mjsunit expectations for variants. R=rmcilroy@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [test] Split Ignition mjsunit expectations for variants. R=rmcilroy@chromium.org ========== to ========== [test] Split Ignition mjsunit expectations for variants. R=rmcilroy@chromium.org Committed: https://crrev.com/b531266da18af293c5ae9a80248b5bdf96568eb6 Cr-Commit-Position: refs/heads/master@{#38483} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b531266da18af293c5ae9a80248b5bdf96568eb6 Cr-Commit-Position: refs/heads/master@{#38483} |
