[test] Split Ignition mjsunit expectations for variants.

test/mjsunit/mjsunit.status

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 166 matching lines @@
   'es6/unicode-regexp-ignore-case': [PASS, ['no_i18n == True', FAIL]],
   'es6/unicode-regexp-ignore-case-noi18n': [FAIL, ['no_i18n == True', PASS]],
   'regress/regress-5036': [PASS, ['no_i18n == True', FAIL]],
   # desugaring regexp property class relies on ICU.
   'harmony/regexp-property-*': [PASS, ['no_i18n == True', FAIL]],
 
   # TODO(bmeurer): Flaky timeouts (sometimes <1s, sometimes >3m).
   'unicodelctest': [PASS, NO_VARIANTS],
   'unicodelctest-no-optimization': [PASS, NO_VARIANTS],
 
-  ############################################################################
-  # Ignition
-
-  # TODO(mythria, 4780): Related to type feedback for calls in interpreter.
-  'array-literal-feedback': [PASS, NO_IGNITION],
-  'regress/regress-4121': [PASS, NO_IGNITION],
-
-  # TODO(4680): Test doesn't know about three tier compiler pipeline.
-  'assert-opt-and-deopt': [PASS, NO_IGNITION],
-
-  # BUG(rmcilroy,4989): Function is optimized without type feedback and so immediately deopts again, causing check failure in the test.
-  'compiler/deopt-inlined-from-call': [PASS, NO_IGNITION],
-  'compiler/increment-typefeedback': [PASS, NO_IGNITION],
-  'compiler/manual-concurrent-recompile': [PASS, NO_IGNITION],
-  'constant-folding-2': [PASS, NO_IGNITION],
-  'debug-is-active': [PASS, NO_IGNITION],
-  'deopt-with-fp-regs': [PASS, NO_IGNITION],
-  'deserialize-optimize-inner': [PASS, NO_IGNITION],
-  'div-mul-minus-one': [PASS, NO_IGNITION],
-  'double-intrinsics': [PASS, NO_IGNITION],
-  'elements-transition-hoisting': [PASS, NO_IGNITION],
-  'es6/block-let-crankshaft': [PASS, NO_IGNITION],
-  'es6/block-let-crankshaft-sloppy': [PASS, NO_IGNITION],
-  'getters-on-elements': [PASS, NO_IGNITION],
-  'harmony/do-expressions': [PASS, NO_IGNITION],
-  'math-floor-of-div-minus-zero': [PASS, NO_IGNITION],
-  'regress/regress-2132': [PASS, NO_IGNITION],
-  'regress/regress-2339': [PASS, NO_IGNITION],
-  'regress/regress-3176': [PASS, NO_IGNITION],
-  'regress/regress-3709': [PASS, NO_IGNITION],
-  'regress/regress-385565': [PASS, NO_IGNITION],
-  'regress/regress-crbug-594183': [PASS, NO_IGNITION],
-  'regress/regress-embedded-cons-string': [PASS, NO_IGNITION],
-  'regress/regress-map-invalidation-2': [PASS, NO_IGNITION],
-  'regress/regress-param-local-type': [PASS, NO_IGNITION],
-  'regress/regress-prepare-break-while-recompile': [PASS, NO_IGNITION],
-  'shift-for-integer-div': [PASS, NO_IGNITION],
-  'sin-cos': [PASS, NO_IGNITION],
-  'smi-mul-const': [PASS, NO_IGNITION],
-  'smi-mul': [PASS, NO_IGNITION],
-  'unary-minus-deopt': [PASS, NO_IGNITION],
-  'array-constructor-feedback': [PASS, NO_IGNITION],
-  'array-feedback': [PASS, NO_IGNITION],
-  'allocation-site-info': [PASS, NO_IGNITION],
-
   # TODO(rmcilroy,5038): Crashes in Deoptimizer::PatchCodeForDeoptimization on
   # nosnap builds when --stress-opt and --turbo-from-bytecode is enabled.
   'harmony/generators-turbo': [PASS, FAST_VARIANTS],
 }],  # ALWAYS
 
 ['novfp3 == True', {
   'asm/embenchen/box2d': [SKIP],
   'asm/embenchen/zlib': [SKIP],
   'asm/embenchen/memops': [SKIP],
   'asm/embenchen/lua_binarytrees': [SKIP],
@@ skipping 143 matching lines @@
   'regress/regress-crbug-217858': [PASS, SLOW],
   'regress/regress-create-exception': [PASS, SLOW],
   'regress/regress-json-stringify-gc': [PASS, SLOW],
   'string-indexof-2': [PASS, SLOW],
   'unicodelctest-no-optimization': [PASS, SLOW],
   'unicodelctest': [PASS, SLOW],
   'unicode-test': [PASS, SLOW],
   'whitespaces': [PASS, TIMEOUT, SLOW],
 
   # TODO(rmcilroy,4680): Arm64 specific timeouts.
-  'asm/construct-double': [PASS, NO_IGNITION],
-  'compiler/osr-one': [PASS, NO_IGNITION],
-  'compiler/osr-two': [PASS, NO_IGNITION],
-  'wasm/asm-wasm-i32': [PASS, NO_IGNITION],
-  'wasm/asm-wasm-u32': [PASS, NO_IGNITION],
+  'asm/construct-double': [PASS, ['variant == ignition', SKIP]],
+  'compiler/osr-one': [PASS, ['variant == ignition', SKIP]],
+  'compiler/osr-two': [PASS, ['variant == ignition', SKIP]],
+  'wasm/asm-wasm-i32': [PASS, ['variant == ignition', SKIP]],
+  'wasm/asm-wasm-u32': [PASS, ['variant == ignition', SKIP]],
 }],  # 'arch == arm64'
 
 ['arch == arm64 and mode == debug and simulator_run == True', {
 
   # Pass but take too long with the simulator in debug mode.
   'array-sort': [PASS, TIMEOUT],
   'packed-elements': [SKIP],
   'regexp-global': [SKIP],
   'math-floor-of-div': [PASS, TIMEOUT],
   'math-floor-of-div-nosudiv': [PASS, TIMEOUT],
   'unicodelctest': [PASS, TIMEOUT],
   'unicodelctest-no-optimization': [PASS, TIMEOUT],
   # Issue 3219:
   'getters-on-elements': [PASS, ['gc_stress == True', FAIL]],
 
   # Ignition.
-  'es6/templates': [PASS, ['no_snap and mode == debug', NO_IGNITION]],
-  'regress/regress-crbug-364374': [PASS, ['no_snap and mode == debug', NO_IGNITION]],
+  'es6/templates': [PASS, ['no_snap and mode == debug and variant == ignition', SKIP]],
+  'regress/regress-crbug-364374': [PASS, ['no_snap and mode == debug and variant == ignition', SKIP]],
 }],  # 'arch == arm64 and mode == debug and simulator_run == True'
 
 ##############################################################################
 ['asan == True', {
   # Skip tests not suitable for ASAN.
   'big-array-literal': [SKIP],
   'big-object-literal': [SKIP],
   'regress/regress-crbug-178790': [SKIP],
 
   # Exception thrown during bootstrapping on ASAN builds, see issue 4236.
   'regress/regress-1132': [SKIP],
 }],  # 'asan == True'
 
 ##############################################################################
 ['msan == True', {
   # Skip tests not suitable for MSAN.
   'big-array-literal': [SKIP],
   # ICU upstream issues.
   'date': [SKIP],
   'deep-recursion': [SKIP],
   'regress/regress-builtinbust-7': [SKIP],
   'string-localecompare': [SKIP],
 
   # TODO(mythria,4680): All of these tests have large loops and hence slow
   # and timeout.
-  'compiler/osr-big': [PASS, NO_IGNITION],
-  'compiler/osr-nested': [PASS, NO_IGNITION],
-  'regress/regress-298269': [PASS, NO_IGNITION],
-  'regress/regress-crbug-319860': [PASS, NO_IGNITION],
-  'regress/regress-deep-proto': [PASS, NO_IGNITION],
-  'try': [PASS, NO_IGNITION],
+  'compiler/osr-big': [PASS, ['variant == ignition', SKIP]],
+  'compiler/osr-nested': [PASS, ['variant == ignition', SKIP]],
+  'regress/regress-298269': [PASS, ['variant == ignition', SKIP]],
+  'regress/regress-crbug-319860': [PASS, ['variant == ignition', SKIP]],
+  'regress/regress-deep-proto': [PASS, ['variant == ignition', SKIP]],
+  'try': [PASS, ['variant == ignition', SKIP]],
   # Too slow for interpreter and msan.
-  'es6/tail-call-megatest*': [PASS, NO_IGNITION],
+  'es6/tail-call-megatest*': [PASS, ['variant == ignition', SKIP]],

[rmcilroy, 2016/08/08 14:23:39]

I don't think you can do this with the new variant options - I think they have
to be top level.

[Michael Starzinger, 2016/08/08 16:15:50]

Done. Yep, also realized that while sending it to the CQ. Fixed by moving it
into the ignition section.

 
   # Too slow.
   'harmony/regexp-property-lu-ui': [SKIP],
 }],  # 'msan == True'
 
 ##############################################################################
 ['arch == arm or arch == android_arm', {
 
   # Slow tests which times out in debug mode.
   'try': [PASS, ['mode == debug', SKIP]],
@@ skipping 29 matching lines @@
   'compiler/osr-with-args': [PASS, SLOW],
   'mirror-object': [PASS, SLOW],
   'packed-elements': [PASS, SLOW],
   'regress/regress-2185-2': [PASS, SLOW],
   'regress/regress-2790': [PASS, SLOW],
   'regress/regress-91008': [PASS, SLOW],
   'regress/regress-json-stringify-gc': [PASS, SLOW],
   'string-indexof-2': [PASS, TIMEOUT],
 
   # TODO(rmcilroy,4680): Arm specific timeouts.
-  'compiler/osr-one': [PASS, NO_IGNITION],
-  'compiler/osr-two': [PASS, NO_IGNITION],
-  'regress/regress-1257': [PASS, NO_IGNITION],
+  'compiler/osr-one': [PASS, ['variant == ignition', SKIP]],
+  'compiler/osr-two': [PASS, ['variant == ignition', SKIP]],
+  'regress/regress-1257': [PASS, ['variant == ignition', SKIP]],
 }],  # 'arch == arm or arch == android_arm'
 
 ##############################################################################
 ['arch == mipsel or arch == mips', {
 
   # Slow tests which times out in debug mode.
   'try': [PASS, ['mode == debug', SKIP]],
   'debug-scripts-request': [PASS, ['mode == debug', SKIP]],
   'array-constructor': [PASS, ['mode == debug', SKIP]],
 
@@ skipping 182 matching lines @@
   'big-object-literal': [SKIP],
   'ignition/regress-599001-verifyheap': [SKIP],
   'unicode-test': [SKIP],
 
 }],  # variant == turbofan_opt
 
 ##############################################################################
 ['variant == ignition', {
   'debug-liveedit-double-call': [FAIL],
   'regress-sync-optimized-lists': [FAIL],
+
+  # TODO(mythria, 4780): Related to type feedback for calls in interpreter.
+  'array-literal-feedback': [FAIL],
+  'regress/regress-4121': [FAIL],
+
+  # TODO(4680): Test doesn't know about three tier compiler pipeline.
+  'assert-opt-and-deopt': [FAIL],
+
+  # BUG(rmcilroy,4989): Function is optimized without type feedback and so immediately deopts again, causing check failure in the test.
+  'compiler/deopt-inlined-from-call': [FAIL],
+  'compiler/increment-typefeedback': [FAIL],
+  'compiler/manual-concurrent-recompile': [FAIL],
+  'constant-folding-2': [FAIL],
+  'debug-is-active': [FAIL],
+  'deopt-with-fp-regs': [FAIL],
+  'deserialize-optimize-inner': [FAIL],
+  'div-mul-minus-one': [FAIL],
+  'double-intrinsics': [FAIL],
+  'elements-transition-hoisting': [FAIL],
+  'es6/block-let-crankshaft': [FAIL],
+  'es6/block-let-crankshaft-sloppy': [FAIL],
+  'getters-on-elements': [FAIL],
+  'harmony/do-expressions': [FAIL],
+  'math-floor-of-div-minus-zero': [FAIL],
+  'regress/regress-2132': [FAIL],
+  'regress/regress-2339': [FAIL],
+  'regress/regress-3176': [FAIL],
+  'regress/regress-3709': [FAIL],
+  'regress/regress-385565': [FAIL],
+  'regress/regress-crbug-594183': [FAIL],
+  'regress/regress-embedded-cons-string': [FAIL],
+  'regress/regress-map-invalidation-2': [FAIL],
+  'regress/regress-param-local-type': [FAIL],
+  'regress/regress-prepare-break-while-recompile': [FAIL],
+  'shift-for-integer-div': [FAIL],
+  'sin-cos': [FAIL],
+  'smi-mul-const': [FAIL],
+  'smi-mul': [FAIL],
+  'unary-minus-deopt': [FAIL],
+  'array-constructor-feedback': [FAIL],
+  'array-feedback': [FAIL],
+  'allocation-site-info': [FAIL],
 }],  # variant == ignition
 
 ##############################################################################
 ['variant == ignition_staging', {
   'allocation-site-info': [FAIL],
   'array-constructor-feedback': [FAIL],
   'array-feedback': [FAIL],
   'array-literal-feedback': [FAIL],
   'assert-opt-and-deopt': [FAIL],
   'compiler/deopt-inlined-from-call': [FAIL],
@@ skipping 105 matching lines @@
 ##############################################################################
 ['gcov_coverage', {
   # Tests taking too long.
   'array-functions-prototype-misc': [SKIP],
 
   # Stack overflow.
   'big-array-literal': [SKIP],
 }],  # 'gcov_coverage'
 
 ]