Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2228853002: [test] Fully deprecate NO_IGNITION directive. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-variants-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fully deprecate NO_IGNITION directive. R=machenbach@chromium.org Committed: https://crrev.com/c403ab7f57b10fecb899dc46823f7cbc21c3d143 Cr-Commit-Position: refs/heads/master@{#38494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M test/intl/intl.status View 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 3 chunks +1 line, -7 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-09 08:17:38 UTC) #1
rmcilroy
Awesome, LGTM. Thanks
4 years, 4 months ago (2016-08-09 08:19:56 UTC) #2
Michael Achenbach
LGTM!
4 years, 4 months ago (2016-08-09 08:53:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228853002/1
4 years, 4 months ago (2016-08-09 13:06:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 13:07:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 13:08:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c403ab7f57b10fecb899dc46823f7cbc21c3d143
Cr-Commit-Position: refs/heads/master@{#38494}

Powered by Google App Engine
This is Rietveld 408576698