Converts mash to use the common non-client frame

Converts mash to use the common non-client frame

I left TODOs for figuring out a better way to get insets rather than
assuming the code works a particular way.

BUG=634972
TEST=mostly covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3
Cr-Commit-Position: refs/heads/master@{#410661}

[sky, 2016-08-08 23:31:06]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:31:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-08 23:32:27]

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/non_client_fram...
File ash/mus/non_client_frame_controller.cc (left):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/non_client_fram...
ash/mus/non_client_frame_controller.cc:145: void CenterWindow(const gfx::Size&
size) override {
These overrides are no longer necessary because of
https://codereview.chromium.org/2225833003/ .

[James Cook, 2016-08-09 00:37:10]

LGTM

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/BUILD.gn
File ash/mus/BUILD.gn (left):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/BUILD.gn#oldcode41
ash/mus/BUILD.gn:41: "frame/caption_buttons/caption_button_types.h",
Woo hoo! It's lovely to see this much code deletion.

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus.h:286: bool use_empty_minimum_size_ = false;
optional nit: use_empty_minimum_size_for_testing_ ? Then you wouldn't need the
second part of the comment

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus_test_api.h (right):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus_test_api.h:15: WmWindowMusTestApi(WmWindow* window)
nit: explicit

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus_test_api.h:17: WmWindowMusTestApi(WmWindowMus*
window) : window_(window) {}
ditto

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/non_client_fram...
File ash/mus/non_client_frame_controller.cc (left):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/non_client_fram...
ash/mus/non_client_frame_controller.cc:145: void CenterWindow(const gfx::Size&
size) override {
On 2016/08/08 23:32:27, sky wrote:
> These overrides are no longer necessary because of
> https://codereview.chromium.org/2225833003/ .

Hooray! No more tricky empty overrides.

[commit-bot: I haz the power, 2016-08-09 00:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:46:50]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-09 13:16:48]

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus.h (right):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus.h:286: bool use_empty_minimum_size_ = false;
On 2016/08/09 00:37:10, James Cook wrote:
> optional nit: use_empty_minimum_size_for_testing_ ? Then you wouldn't need the
> second part of the comment
> 

Done.

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus_test_api.h (right):

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus_test_api.h:15: WmWindowMusTestApi(WmWindow* window)
On 2016/08/09 00:37:10, James Cook wrote:
> nit: explicit

Done.

https://codereview.chromium.org/2227643003/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus_test_api.h:17: WmWindowMusTestApi(WmWindowMus*
window) : window_(window) {}
On 2016/08/09 00:37:10, James Cook wrote:
> ditto

Done.

[sky, 2016-08-09 13:17:51]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-09 13:17:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2227643003/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2016-08-09 13:18:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 14:27:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-09 14:29:23]

Description was changed from

==========
Converts mash to use the common non-client frame

I left TODOs for figuring out a better way to get insets rather than
assuming the code works a particular way.

BUG=634972
TEST=mostly covered by tests
R=jamescook@chromium.org
==========

to

==========
Converts mash to use the common non-client frame

I left TODOs for figuring out a better way to get insets rather than
assuming the code works a particular way.

BUG=634972
TEST=mostly covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3
Cr-Commit-Position: refs/heads/master@{#410661}
==========

[commit-bot: I haz the power, 2016-08-09 14:29:25]

Patchset 4 (id:??) landed as
https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3
Cr-Commit-Position: refs/heads/master@{#410661}