Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ash/common/frame/header_painter_util.cc

Issue 2227643003: Converts mash to use the common non-client frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_widget_mus_fix
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/frame/custom_frame_view_ash.cc ('k') | ash/mus/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/frame/header_painter_util.cc
diff --git a/ash/common/frame/header_painter_util.cc b/ash/common/frame/header_painter_util.cc
index dfd545455215b19481037c77e49c457bfb170a14..f9e1595840e3c1191b8bb01bfdae9a6da3aa1a30 100644
--- a/ash/common/frame/header_painter_util.cc
+++ b/ash/common/frame/header_painter_util.cc
@@ -84,7 +84,8 @@ bool HeaderPainterUtil::CanAnimateActivation(views::Widget* widget) {
// TODO(sky): Expose a better way to determine this rather than assuming the
// parent is a toplevel container.
WmWindow* window = WmLookup::Get()->GetWindowForWidget(widget);
- if (!window || !window->GetParent())
+ // TODO(sky): GetParent()->GetLayer() is for mash until animations ported.
+ if (!window || !window->GetParent() || !window->GetParent()->GetLayer())
return true;
ui::LayerAnimator* parent_layer_animator =
« no previous file with comments | « ash/common/frame/custom_frame_view_ash.cc ('k') | ash/mus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698