Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: ash/common/frame/header_painter_util.cc

Issue 2227643003: Converts mash to use the common non-client frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_widget_mus_fix
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/frame/custom_frame_view_ash.cc ('k') | ash/mus/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/frame/header_painter_util.h" 5 #include "ash/common/frame/header_painter_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/common/wm_lookup.h" 9 #include "ash/common/wm_lookup.h"
10 #include "ash/common/wm_window.h" 10 #include "ash/common/wm_window.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // static 77 // static
78 bool HeaderPainterUtil::CanAnimateActivation(views::Widget* widget) { 78 bool HeaderPainterUtil::CanAnimateActivation(views::Widget* widget) {
79 // Do not animate the header if the parent (e.g. 79 // Do not animate the header if the parent (e.g.
80 // kShellWindowId_DefaultContainer) is already animating. All of the 80 // kShellWindowId_DefaultContainer) is already animating. All of the
81 // implementers of HeaderPainter animate activation by continuously painting 81 // implementers of HeaderPainter animate activation by continuously painting
82 // during the animation. This gives the parent's animation a slower frame 82 // during the animation. This gives the parent's animation a slower frame
83 // rate. 83 // rate.
84 // TODO(sky): Expose a better way to determine this rather than assuming the 84 // TODO(sky): Expose a better way to determine this rather than assuming the
85 // parent is a toplevel container. 85 // parent is a toplevel container.
86 WmWindow* window = WmLookup::Get()->GetWindowForWidget(widget); 86 WmWindow* window = WmLookup::Get()->GetWindowForWidget(widget);
87 if (!window || !window->GetParent()) 87 // TODO(sky): GetParent()->GetLayer() is for mash until animations ported.
88 if (!window || !window->GetParent() || !window->GetParent()->GetLayer())
88 return true; 89 return true;
89 90
90 ui::LayerAnimator* parent_layer_animator = 91 ui::LayerAnimator* parent_layer_animator =
91 window->GetParent()->GetLayer()->GetAnimator(); 92 window->GetParent()->GetLayer()->GetAnimator();
92 return !parent_layer_animator->IsAnimatingProperty( 93 return !parent_layer_animator->IsAnimatingProperty(
93 ui::LayerAnimationElement::OPACITY) && 94 ui::LayerAnimationElement::OPACITY) &&
94 !parent_layer_animator->IsAnimatingProperty( 95 !parent_layer_animator->IsAnimatingProperty(
95 ui::LayerAnimationElement::VISIBILITY); 96 ui::LayerAnimationElement::VISIBILITY);
96 } 97 }
97 98
98 } // namespace ash 99 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/frame/custom_frame_view_ash.cc ('k') | ash/mus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698