chrome/browser/password_manager/password_manager_interactive_uitest.cc - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/browser/password_manager/password_manager_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_manager_interactive_uitest.cc b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

index 3f5b1230b87597895a6f18c5a69ba7d965bdb66d..b641d80b15599d3bc32539e6d55cea9c44bc646c 100644

--- a/chrome/browser/password_manager/password_manager_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_manager_interactive_uitest.cc

@@ -81,7 +81,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, MAYBE_UsernameChanged) {

// Let the user interact with the page, so that DOM gets modification events,

// needed for autofilling fields.

content::SimulateMouseClickAt(

- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));

+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));

WaitForElementValue("username_field", "temp");

WaitForElementValue("password_field", "random");

@@ -91,7 +91,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, MAYBE_UsernameChanged) {

SimulateUserTypingInField(RenderViewHost(), WebContents(), "username_field");

// TODO(gcasto): Not sure why this click is required.

content::SimulateMouseClickAt(

- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));

+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));

WaitForElementValue("username_field", "tempORARY");

NavigationObserver second_observer(WebContents());