Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new instances Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/password_manager/password_manager_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 2b65d7be7659de14387d50df258844115c3b431b..c5d05d396671a933f4421a9fedf0ad733982bf15 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -849,7 +849,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// Simulate a user click to force an autofill of the form's DOM value, not
// just the suggested value.
content::SimulateMouseClick(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft);
+ WebContents(), 0, blink::WebMouseEvent::Button::Left);
// The form should be filled with the previously submitted username.
std::string get_username =
@@ -1090,7 +1090,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
CheckElementValue("password_field", "");
// Let the user interact with the page.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
// Wait until that interaction causes the password value to be revealed.
WaitForElementValue("password_field", "random");
// And check that after the side-effects of the interaction took place, the
@@ -1683,7 +1683,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
&left));
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(left + 1,
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(left + 1,
top + 1));
// Make sure the popup would be shown.
observing_autofill_client.Wait();
@@ -1930,7 +1930,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
&left));
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(left + 1,
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(left + 1,
top + 1));
// Verify username is not autofilled
ASSERT_TRUE(content::ExecuteScriptAndExtractString(
@@ -1995,7 +1995,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
&left));
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(left + 1,
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(left + 1,
top + 1));
// Verify password has been autofilled
WaitForElementValue("iframe", "password_field", "pa55w0rd");
@@ -2299,7 +2299,7 @@ IN_PROC_BROWSER_TEST_F(
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2347,7 +2347,7 @@ IN_PROC_BROWSER_TEST_F(
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2394,7 +2394,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2454,7 +2454,7 @@ IN_PROC_BROWSER_TEST_F(
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2511,7 +2511,7 @@ IN_PROC_BROWSER_TEST_F(
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2629,7 +2629,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2676,7 +2676,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
@@ -2723,7 +2723,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));
std::string get_username =
"window.domAutomationController.send("
« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/password_manager/password_manager_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698