chrome/browser/password_manager/password_manager_test_base.cc - Issue 2227563003: Refactoring button field and its type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_test_base.cc

Issue 2227563003: Refactoring button field and its type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new instances Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_manager_test_base.cc

diff --git a/chrome/browser/password_manager/password_manager_test_base.cc b/chrome/browser/password_manager/password_manager_test_base.cc

index 6e45005dc69b992d9c746e9da33f92106b538e86..56446659f043d84b8c5cb595333a8a5926933493 100644

--- a/chrome/browser/password_manager/password_manager_test_base.cc

+++ b/chrome/browser/password_manager/password_manager_test_base.cc

@@ -164,7 +164,7 @@ void PasswordManagerBrowserTestBase::VerifyPasswordIsSavedAndFilled(

// Let the user interact with the page, so that DOM gets modification events,

// needed for autofilling fields.

content::SimulateMouseClickAt(

- WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));

+ WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(1, 1));

// Wait until that interaction causes the password value to be revealed.

WaitForElementValue(expected_element, expected_value);