Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2227553003: Use the CHLO packet size, not message size when determining how large a REJ can be. Protected by --… (Closed)

Created:
4 years, 4 months ago by danzh1
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@129101660
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the CHLO packet size, not message size when determining how large a REJ can be. Protected by --quic_use_chlo_packet_size This should reduce number of round trips during the handshake slightly. Merge internal change: 129160718 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -15 lines) Patch
M net/quic/core/crypto/crypto_server_test.cc View 4 chunks +37 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 5 chunks +14 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 3 chunks +5 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/tools/quic/stateless_rejector.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
danzh1
4 years, 4 months ago (2016-08-08 19:23:47 UTC) #1
Ryan Hamilton
4 years, 4 months ago (2016-08-09 16:32:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698