Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: net/quic/test_tools/crypto_test_utils_test.cc

Issue 2227553003: Use the CHLO packet size, not message size when determining how large a REJ can be. Protected by --… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129101660
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/test_tools/crypto_test_utils.h" 5 #include "net/quic/test_tools/crypto_test_utils.h"
6 6
7 #include "net/quic/core/crypto/crypto_server_config_protobuf.h" 7 #include "net/quic/core/crypto/crypto_server_config_protobuf.h"
8 #include "net/quic/core/quic_utils.h" 8 #include "net/quic/core/quic_utils.h"
9 #include "net/quic/test_tools/mock_clock.h" 9 #include "net/quic/test_tools/mock_clock.h"
10 #include "net/test/gtest_util.h" 10 #include "net/test/gtest_util.h"
(...skipping 26 matching lines...) Expand all
37 std::unique_ptr<ProofSource::Details> /* details */) override { 37 std::unique_ptr<ProofSource::Details> /* details */) override {
38 QuicCryptoNegotiatedParameters params; 38 QuicCryptoNegotiatedParameters params;
39 string error_details; 39 string error_details;
40 DiversificationNonce diversification_nonce; 40 DiversificationNonce diversification_nonce;
41 CryptoHandshakeMessage out; 41 CryptoHandshakeMessage out;
42 crypto_config_->ProcessClientHello( 42 crypto_config_->ProcessClientHello(
43 result, /*reject_only=*/false, /*connection_id=*/1, server_ip_, 43 result, /*reject_only=*/false, /*connection_id=*/1, server_ip_,
44 client_addr_, QuicSupportedVersions().front(), QuicSupportedVersions(), 44 client_addr_, QuicSupportedVersions().front(), QuicSupportedVersions(),
45 /*use_stateless_rejects=*/true, /*server_designated_connection_id=*/0, 45 /*use_stateless_rejects=*/true, /*server_designated_connection_id=*/0,
46 clock_, QuicRandom::GetInstance(), compressed_certs_cache_, &params, 46 clock_, QuicRandom::GetInstance(), compressed_certs_cache_, &params,
47 proof_, &out, &diversification_nonce, &error_details); 47 proof_, /*total_framing_overhead=*/50, kDefaultMaxPacketSize, &out,
48 &diversification_nonce, &error_details);
48 // Verify output is a SHLO. 49 // Verify output is a SHLO.
49 EXPECT_EQ(out.tag(), kSHLO) << "Fail to pass validation. Get " 50 EXPECT_EQ(out.tag(), kSHLO) << "Fail to pass validation. Get "
50 << out.DebugString(); 51 << out.DebugString();
51 } 52 }
52 53
53 protected: 54 protected:
54 QuicCryptoServerConfig* crypto_config_; 55 QuicCryptoServerConfig* crypto_config_;
55 IPAddress server_ip_; 56 IPAddress server_ip_;
56 IPEndPoint client_addr_; 57 IPEndPoint client_addr_;
57 const QuicClock* clock_; 58 const QuicClock* clock_;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 &compressed_certs_cache, &full_chlo); 118 &compressed_certs_cache, &full_chlo);
118 // Verify that full_chlo can pass crypto_config's verification. 119 // Verify that full_chlo can pass crypto_config's verification.
119 crypto_config.ValidateClientHello( 120 crypto_config.ValidateClientHello(
120 full_chlo, client_addr.address(), server_ip, version, &clock, &proof, 121 full_chlo, client_addr.address(), server_ip, version, &clock, &proof,
121 new ShloVerifier(&crypto_config, server_ip, client_addr, &clock, &proof, 122 new ShloVerifier(&crypto_config, server_ip, client_addr, &clock, &proof,
122 &compressed_certs_cache)); 123 &compressed_certs_cache));
123 } 124 }
124 125
125 } // namespace test 126 } // namespace test
126 } // namespace net 127 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698