Issue 2228613002: Rollback of internal changelist 128865569.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2228613002: Rollback of internal changelist 128865569. (Closed)

Created:
4 years, 4 months ago by danzh1

Modified:
4 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@129053230

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rollback of internal changelist 128865569. *** Original change description *** Inline PacingSender into QuicSentPacketManager. Guarded by gfe2_reloadable_flag_quic_use_inline_pacing. *** Merge internal change: 129101660 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -111 lines)			Patch
M	net/quic/core/congestion_control/pacing_sender.h	View	3 chunks	+13 lines, -7 lines	0 comments	Download
M	net/quic/core/congestion_control/pacing_sender.cc	View	4 chunks	+11 lines, -31 lines	0 comments	Download
M	net/quic/core/congestion_control/pacing_sender_test.cc	View	3 chunks	+6 lines, -16 lines	0 comments	Download
M	net/quic/core/quic_flags.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/core/quic_flags.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager.cc	View	7 chunks	+22 lines, -43 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2222093002 Patch 1

Dependent Patchsets:

Issue 2227553003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages