[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException uses.

[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=

Committed: https://crrev.com/3306dbc2f89a78ca73628b5fc4b4a3e862e5f0df
Cr-Commit-Position: refs/heads/master@{#38531}

[bgeron, 2016-08-10 09:20:19]

bgeron@google.com changed reviewers:
+ bmeurer@chromium.org, rossberg@chromium.org

[bgeron, 2016-08-10 09:20:20]

Hi Andreas,

We're making sure that Turbofan nodes without kNoThrow are only followed by
IfSuccess/IfException control uses, and no other control uses. I feel
JavascriptToNumber and BuildTrapCode might throw so I added IfSuccess to those.
I marked BuildGrowMemory as kNoThrow after a discussion with ahaas. Do you
concur?

Cheers, Bram

[Benedikt Meurer, 2016-08-10 09:26:10]

lgtm

[bgeron, 2016-08-10 09:26:50]

bgeron@google.com changed reviewers:
+ ahaas@chromium.org
- rossberg@chromium.org

[bgeron, 2016-08-10 09:26:51]

Right, Benedikt meant the other Andreas. Makes so much sense. /facepalm

[Jarin, 2016-08-10 09:47:10]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-08-10 09:47:10]

lgtm

[bgeron, 2016-08-10 09:52:46]

Description was changed from

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in four places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- for WasmGrowMemory.

BUG=
==========

to

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in four places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

[bgeron, 2016-08-10 09:53:01]

Description was changed from

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in four places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

to

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

[ahaas, 2016-08-10 10:34:58]

https://codereview.chromium.org/2226163004/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2226163004/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:253: *control_ptr =
graph()->NewNode(common()->IfSuccess(), node);
node is a call to Runtime::ThrowWasmError, which has as its last line
"isolate->Throw(*error_obj)." Is this a different throw that what you are
talking about in this CL?

[bgeron, 2016-08-10 10:39:46]

The CQ bit was checked by bgeron@google.com

[bgeron, 2016-08-10 10:39:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2226163004/#ps20001
(title: "Merge with master")

[commit-bot: I haz the power, 2016-08-10 10:39:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-10 10:41:03]

lgtm

[bgeron, 2016-08-10 10:41:56]

https://codereview.chromium.org/2226163004/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2226163004/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:253: *control_ptr =
graph()->NewNode(common()->IfSuccess(), node);
On 2016/08/10 10:34:58, ahaas wrote:
> node is a call to Runtime::ThrowWasmError, which has as its last line
> "isolate->Throw(*error_obj)." Is this a different throw that what you are
> talking about in this CL?

Nope, that's it! Committing.

[commit-bot: I haz the power, 2016-08-10 11:34:30]

Description was changed from

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

to

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

[commit-bot: I haz the power, 2016-08-10 11:34:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 11:34:43]

Description was changed from

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=
==========

to

==========
[turbofan] Ensure nodes without kNoThrow have only IfSuccess or IfException
uses.

This adds an IfSuccess control use in three places:

- in the lowering of isinstance,
- in wasm BuildTrapCode,
- in wasm BuildJavaScriptToNumber,
- WasmGrowMemory is marked as kNoThrow.

BUG=

Committed: https://crrev.com/3306dbc2f89a78ca73628b5fc4b4a3e862e5f0df
Cr-Commit-Position: refs/heads/master@{#38531}
==========

[commit-bot: I haz the power, 2016-08-10 11:34:45]

Patchset 2 (id:??) landed as
https://crrev.com/3306dbc2f89a78ca73628b5fc4b4a3e862e5f0df
Cr-Commit-Position: refs/heads/master@{#38531}

[bgeron, 2016-08-10 12:29:08]

Patchset #3 (id:40001) has been deleted