Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2227763004:
[turbofan] Verify nodes without kNoThrow have only IfSuccess or IfException uses. (Closed)
Description[turbofan] Verify nodes without kNoThrow have only IfSuccess or IfException uses.
BUG=
Committed: https://crrev.com/dc38437291a9fa810755dbd9d1b08d4d722483ec
Cr-Commit-Position: refs/heads/master@{#38586}
Patch Set 1 #Patch Set 2 : (dummy upload; fix patchset dependency) #Patch Set 3 : Merge with master, update dependency patchset #Patch Set 4 : Depend on fix for regress-crbug-485410. #Patch Set 5 : Depend on fixed unit test. (mistake) #Patch Set 6 : Depend on fixed unit test. #
Total comments: 2
Patch Set 7 : Localize and inline CHECK_EXTRA. Fix the check as discussed. Make OsrLoopEntry, Start, Tailcall NoT… #
Depends on Patchset: Messages
Total messages: 31 (25 generated)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10705)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10710) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6741) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bgeron@google.com changed reviewers: + jarin@chromium.org
PTAL.
As discussed. Made three opcodes NoThrow. https://codereview.chromium.org/2227763004/diff/90001/src/base/logging.h File src/base/logging.h (right): https://codereview.chromium.org/2227763004/diff/90001/src/base/logging.h#newc... src/base/logging.h:63: } while (0) Removed from next patchset. https://codereview.chromium.org/2227763004/diff/90001/src/compiler/verifier.cc File src/compiler/verifier.cc (right): https://codereview.chromium.org/2227763004/diff/90001/src/compiler/verifier.c... src/compiler/verifier.cc:157: node->opcode() != IrOpcode::kSwitch) { Changed.
Nice! lgtm.
The CQ bit was checked by bgeron@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #7 (id:110001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Verify nodes without kNoThrow have only IfSuccess or IfException uses. BUG= ========== to ========== [turbofan] Verify nodes without kNoThrow have only IfSuccess or IfException uses. BUG= Committed: https://crrev.com/dc38437291a9fa810755dbd9d1b08d4d722483ec Cr-Commit-Position: refs/heads/master@{#38586} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/dc38437291a9fa810755dbd9d1b08d4d722483ec Cr-Commit-Position: refs/heads/master@{#38586} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
