Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2230923002: [turbofan] Fix more places where IfSuccess lacks on a non-NoThrow node. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@p7
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix more places where IfSuccess lacks on a non-NoThrow node. These places were found by the trybots. - regress-crbug-485410 BUG= Committed: https://crrev.com/7c3be98986aa8c5e1390ec5c52b44c77dd9ce079 Cr-Commit-Position: refs/heads/master@{#38572}

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
bgeron
PTAL.
4 years, 4 months ago (2016-08-10 14:41:09 UTC) #3
Jarin
lgtm
4 years, 4 months ago (2016-08-11 04:51:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230923002/20001
4 years, 4 months ago (2016-08-11 08:40:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 09:02:07 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 09:02:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c3be98986aa8c5e1390ec5c52b44c77dd9ce079
Cr-Commit-Position: refs/heads/master@{#38572}

Powered by Google App Engine
This is Rietveld 408576698