Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5308)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.h

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: In response to Wez's #73-75 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider.h
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.h b/blimp/engine/feature/geolocation/blimp_location_provider.h
index d5ffe5ac23ee459b4b1a8a39371a6ed49716b306..39372da41c5dda1edc1d186653844ac6a5bce41c 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.h
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.h
@@ -26,7 +26,7 @@ class BlimpLocationProvider : public device::LocationProvider {
virtual void RequestAccuracy(
GeolocationSetInterestLevelMessage::Level level) = 0;
- virtual void RequestRefresh() = 0;
+ virtual void OnPermissionGranted() = 0;
Wez 2016/08/24 04:13:17 nit: I'd suggest leaving this as RequestRefresh(),
CJ 2016/08/24 21:32:05 Done.
virtual void SetUpdateCallback(
const GeopositionReceivedCallback& callback) = 0;
};
@@ -37,8 +37,7 @@ class BlimpLocationProvider : public device::LocationProvider {
// device::LocationProvider implementation.
bool StartProvider(bool high_accuracy) override;
void StopProvider() override;
- void GetPosition(device::Geoposition* position) override;
- void RequestRefresh() override;
+ const device::Geoposition& GetPosition() override;
void OnPermissionGranted() override;
void SetUpdateCallback(
const LocationProviderUpdateCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698