Gets rid of the LocationArbitrator interface, in preference for LocationProvider.

blimp/engine/feature/geolocation/blimp_location_provider.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 #define BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 
 #include "base/memory/weak_ptr.h"
 #include "blimp/common/proto/geolocation.pb.h"
 #include "device/geolocation/geoposition.h"
 #include "device/geolocation/location_provider.h"
 
 namespace blimp {
 namespace engine {
 
 // Location provider for Blimp using the device's provider over the network.
 class BlimpLocationProvider : public device::LocationProvider {
  public:
   // A delegate that implements a subset of LocationProvider's functions.
   class Delegate {
    public:
     using GeopositionReceivedCallback =
         base::Callback<void(const device::Geoposition&)>;
 
     virtual ~Delegate() {}
 
     virtual void RequestAccuracy(
         GeolocationSetInterestLevelMessage::Level level) = 0;
-    virtual void RequestRefresh() = 0;
+    virtual void OnPermissionGranted() = 0;

[Wez, 2016/08/24 04:13:17]

nit: I'd suggest leaving this as RequestRefresh(), since the delegate doesn't
have any notion of permissions - only the LocationProvider cares about
permissions being granted, and the call it makes to the Delegate really is just
to get it to refresh the location ASAP (I think ;)

[CJ, 2016/08/24 21:32:05]

Done.

     virtual void SetUpdateCallback(
         const GeopositionReceivedCallback& callback) = 0;
   };
 
   explicit BlimpLocationProvider(base::WeakPtr<Delegate> delegate);
   ~BlimpLocationProvider() override;
 
   // device::LocationProvider implementation.
   bool StartProvider(bool high_accuracy) override;
   void StopProvider() override;
-  void GetPosition(device::Geoposition* position) override;
-  void RequestRefresh() override;
+  const device::Geoposition& GetPosition() override;
   void OnPermissionGranted() override;
   void SetUpdateCallback(
       const LocationProviderUpdateCallback& callback) override;
 
  private:
   // This delegate handles a subset of the LocationProvider functionality.
   base::WeakPtr<Delegate> delegate_;
 
   device::Geoposition cached_position_;
 
   // True if a successful StartProvider call has occured.
   bool is_started_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpLocationProvider);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_