Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.cc

Issue 2226143002: Gets rid of the LocationArbitrator interface, in preference for LocationProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: In response to Wez's #73-75 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider.cc
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.cc b/blimp/engine/feature/geolocation/blimp_location_provider.cc
index eed675f8b45460592e693de4fdb6e6407a642466..9fd039774ab36b89f777a437f3f36fdd673ecb34 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.cc
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.cc
@@ -44,21 +44,17 @@ void BlimpLocationProvider::StopProvider() {
}
}
-void BlimpLocationProvider::GetPosition(device::Geoposition* position) {
- *position = cached_position_;
+const device::Geoposition& BlimpLocationProvider::GetPosition() {
+ return cached_position_;
}
-void BlimpLocationProvider::RequestRefresh() {
+void BlimpLocationProvider::OnPermissionGranted() {
DCHECK(is_started_);
if (delegate_) {
- delegate_->RequestRefresh();
+ delegate_->OnPermissionGranted();
}
}
-void BlimpLocationProvider::OnPermissionGranted() {
- RequestRefresh();
-}
-
void BlimpLocationProvider::SetUpdateCallback(
const LocationProviderUpdateCallback& callback) {
if (delegate_) {

Powered by Google App Engine
This is Rietveld 408576698